Re: [PATCH 07/10] platform/x86/amd/pmf: Use amd_pmf_update_bios_inputs() helper

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Fri, 9 May 2025, Shyam Sundar S K wrote:

> Use amd_pmf_update_bios_inputs() helper function to update the custom
> BIOS inputs.
> 
> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/platform/x86/amd/pmf/spc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
> index be6ffb823efc..0cd50d342b11 100644
> --- a/drivers/platform/x86/amd/pmf/spc.c
> +++ b/drivers/platform/x86/amd/pmf/spc.c
> @@ -125,15 +125,12 @@ static void amd_pmf_get_custom_bios_inputs(struct amd_pmf_dev *pdev,
>  		&in->ev_info.bios_input3, &in->ev_info.bios_input4, &in->ev_info.bios_input5,
>  		&in->ev_info.bios_input6, &in->ev_info.bios_input7, &in->ev_info.bios_input8,
>  		&in->ev_info.bios_input9, &in->ev_info.bios_input10};
> -	int i;
>  
>  	if (!(pdev->req.pending_req || pdev->req1.pending_req))
>  		return;
>  
> -	for (i = 0; i < ARRAY_SIZE(custom_bios_inputs); i++) {
> -		if (pdev->req.pending_req & custom_bios_inputs[i].bit_mask)
> -			*bios_inputs[i] = pdev->req.custom_policy[i];
> -	}
> +	amd_pmf_update_bios_inputs(pdev, bios_inputs, custom_bios_inputs, pdev->req.pending_req,
> +				   pdev->req.custom_policy);

Why is this in own patch and not in the one introducing 
amd_pmf_update_bios_inputs() ?

>  	if (pdev->smart_pc_enabled && pdev->pmf_if_version == PMF_IF_V1 &&
>  	    is_apmf_bios_input_notifications_supported(pdev)) {
> 

-- 
 i.