Re: [PATCH 05/10] platform/x86/amd/pmf: Add helper to verify BIOS input notifications are enable/disable

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Fri, 9 May 2025, Shyam Sundar S K wrote:

> Implement a helper function to check if BIOS input notifications are
> enabled or disabled.
> 
> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/platform/x86/amd/pmf/acpi.c | 7 +++++++
>  drivers/platform/x86/amd/pmf/pmf.h  | 2 ++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c
> index f75f7ecd8cd9..ab63582c9d0b 100644
> --- a/drivers/platform/x86/amd/pmf/acpi.c
> +++ b/drivers/platform/x86/amd/pmf/acpi.c
> @@ -161,6 +161,11 @@ int is_apmf_func_supported(struct amd_pmf_dev *pdev, unsigned long index)
>  	return !!(pdev->supported_func & BIT(index - 1));
>  }
>  
> +int is_apmf_bios_input_notifications_supported(struct amd_pmf_dev *pdev)
> +{
> +	return !!(pdev->notifications & GENMASK(16, 7));

Name that GENMASK() although I wonder if custom_bios_inputs_v1 you 
introduced later on should be reused here to do this check. It would keep 
the code in cync

> +}
> +
>  int apts_get_static_slider_granular_v2(struct amd_pmf_dev *pdev,
>  				       struct amd_pmf_apts_granular_output *data, u32 apts_idx)
>  {
> @@ -385,6 +390,8 @@ static int apmf_if_verify_interface(struct amd_pmf_dev *pdev)
>  
>  	pdev->pmf_if_version = output.version;
>  
> +	pdev->notifications =  output.notification_mask;

Extra space

> +
>  	return 0;
>  }
>  
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index 27458a7c221b..2deae43aca63 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -377,6 +377,7 @@ struct amd_pmf_dev {
>  	struct resource *res;
>  	struct apmf_sbios_req_v2 req; /* To get custom bios pending request */
>  	struct mutex cb_mutex;
> +	u32 notifications;
>  };
>  
>  struct apmf_sps_prop_granular_v2 {
> @@ -799,6 +800,7 @@ int apmf_install_handler(struct amd_pmf_dev *pmf_dev);
>  int apmf_os_power_slider_update(struct amd_pmf_dev *dev, u8 flag);
>  int amd_pmf_set_dram_addr(struct amd_pmf_dev *dev, bool alloc_buffer);
>  int amd_pmf_notify_sbios_heartbeat_event_v2(struct amd_pmf_dev *dev, u8 flag);
> +int is_apmf_bios_input_notifications_supported(struct amd_pmf_dev *pdev);
>  
>  /* SPS Layer */
>  int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf);
> 

-- 
 i.