[PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Choong Yong Liang]

From: David E. Box <david.e.box@linux.intel.com>

Introduce a configuration option that allows users to build the
intel_pmc_ipc driver without ACPI support. This is useful for
systems where ACPI is not available or desired.

Based on the discussion from the patch [1], it was necessary to
provide this option to accommodate specific use cases.

Link: https://patchwork.kernel.org/project/netdevbpf/patch/20250227121522.1802832-6-yong.liang.choong@linux.intel.com/#26280764 [1]

Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Co-developed-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>

---
v2 Changes:
- Updated the patch description based on the comment
- Update the author correctly
- Used "#ifdef" instead of "#if" for CONFIG_ACPI
- Placed "#ifdef" inside the function

v1: https://patchwork.kernel.org/project/platform-driver-x86/patch/20250312022955.1418234-1-yong.liang.choong@linux.intel.com/
---
---
 include/linux/platform_data/x86/intel_pmc_ipc.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/platform_data/x86/intel_pmc_ipc.h b/include/linux/platform_data/x86/intel_pmc_ipc.h
index 6e603a8c075f..1d34435b7001 100644
--- a/include/linux/platform_data/x86/intel_pmc_ipc.h
+++ b/include/linux/platform_data/x86/intel_pmc_ipc.h
@@ -36,6 +36,7 @@ struct pmc_ipc_rbuf {
  */
 static inline int intel_pmc_ipc(struct pmc_ipc_cmd *ipc_cmd, struct pmc_ipc_rbuf *rbuf)
 {
+#ifdef CONFIG_ACPI
 	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
 	union acpi_object params[PMC_IPCS_PARAM_COUNT] = {
 		{.type = ACPI_TYPE_INTEGER,},
@@ -89,6 +90,9 @@ static inline int intel_pmc_ipc(struct pmc_ipc_cmd *ipc_cmd, struct pmc_ipc_rbuf
 	}
 
 	return 0;
+#else
+	return -ENODEV;
+#endif /* CONFIG_ACPI */
 }
 
 #endif /* INTEL_PMC_IPC_H */
-- 
2.34.1

Re: [PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Andy Shevchenko]

On Thu, Mar 13, 2025 at 10:55 AM Choong Yong Liang
<yong.liang.choong@linux.intel.com> wrote:
>
> From: David E. Box <david.e.box@linux.intel.com>
>
> Introduce a configuration option that allows users to build the
> intel_pmc_ipc driver without ACPI support. This is useful for
> systems where ACPI is not available or desired.
>
> Based on the discussion from the patch [1], it was necessary to
> provide this option to accommodate specific use cases.

> Link: https://patchwork.kernel.org/project/netdevbpf/patch/20250227121522.1802832-6-yong.liang.choong@linux.intel.com/#26280764 [1]

>

No blank line here, but I think Hans or Ilpo may tweak this when applying.

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Thanks!

> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> Co-developed-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

On Thu, 13 Mar 2025, Andy Shevchenko wrote:

> On Thu, Mar 13, 2025 at 10:55 AM Choong Yong Liang
> <yong.liang.choong@linux.intel.com> wrote:
> >
> > From: David E. Box <david.e.box@linux.intel.com>
> >
> > Introduce a configuration option that allows users to build the
> > intel_pmc_ipc driver without ACPI support. This is useful for
> > systems where ACPI is not available or desired.
> >
> > Based on the discussion from the patch [1], it was necessary to
> > provide this option to accommodate specific use cases.
> 
> > Link: https://patchwork.kernel.org/project/netdevbpf/patch/20250227121522.1802832-6-yong.liang.choong@linux.intel.com/#26280764 [1]
> 
> >
> 
> No blank line here, but I think Hans or Ilpo may tweak this when applying.
> 
> Otherwise LGTM,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> Thanks!

Hi both,

The original commit went through net-next tree so I cannot take this into 
pdx86 tree until after the merge window. It seems low impact enough that 
coordinating with the netdev might not be worth the effort.

To get it going through net-next tree, you'd need to submit v3 so that in 
addition to the current receipients, all relevant netdev people & ML are 
included as receipients. But I'd be fine if you leave it until after the 
merge window and I can then handle it then.

> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > Co-developed-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> > Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>

-- 
 i.

Re: [PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Choong Yong Liang]

On 14/3/2025 7:56 pm, Ilpo Järvinen wrote:

> Hi both,
> 
> The original commit went through net-next tree so I cannot take this into
> pdx86 tree until after the merge window. It seems low impact enough that
> coordinating with the netdev might not be worth the effort.
> 
> To get it going through net-next tree, you'd need to submit v3 so that in
> addition to the current receipients, all relevant netdev people & ML are
> included as receipients. But I'd be fine if you leave it until after the
> merge window and I can then handle it then.
> 

Hi Ilpo,

I believe we can leave the patch until after the merge window.
This approach would simplify the merging process without needing assistance 
from the netdev maintainer for the platform code.

Thank you for your support.

Re: [PATCH v2] platform/x86: intel_pmc_ipc: add option to build without ACPI

[Ilpo Järvinen]

On Thu, 13 Mar 2025 16:55:26 +0800, Choong Yong Liang wrote:

> Introduce a configuration option that allows users to build the
> intel_pmc_ipc driver without ACPI support. This is useful for
> systems where ACPI is not available or desired.
> 
> Based on the discussion from the patch [1], it was necessary to
> provide this option to accommodate specific use cases.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: intel_pmc_ipc: add option to build without ACPI
      commit: d8455a63f731b4f585acc4d49fd7ad78db63b3d0

--
 i.