From: Mario Limonciello <mario.limonciello@amd.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
hdegoede@redhat.com, markgross@kernel.org,
ilpo.jarvinen@linux.intel.com, basavaraj.natikar@amd.com,
jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: Patil.Reddy@amd.com, platform-driver-x86@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v6 13/15] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()
Date: Mon, 4 Dec 2023 13:02:45 -0600 [thread overview]
Message-ID: <ba6ded1b-7132-4165-b6be-77211c014e08@amd.com> (raw)
In-Reply-To: <20231204101548.1458499-14-Shyam-sundar.S-k@amd.com>
On 12/4/2023 04:15, Shyam Sundar S K wrote:
> From: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>
> Current amd_sfh driver has float_to_int() to convert units from
> float to int. This is fine until this function gets called outside of
> the current scope of file.
>
> Add a prefix "amd_sfh" to float_to_int() so that function represents
> the driver name. This function will be called by multiple callers in the
> next patch.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Co-developed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 28 ++++++++++---------
> .../amd-sfh-hid/sfh1_1/amd_sfh_interface.h | 1 +
> 2 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c
> index 8a037de08e92..33fbdde8aff0 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c
> @@ -132,7 +132,7 @@ static void get_common_inputs(struct common_input_property *common, int report_i
> common->event_type = HID_USAGE_SENSOR_EVENT_DATA_UPDATED_ENUM;
> }
>
> -static int float_to_int(u32 flt32_val)
> +int amd_sfh_float_to_int(u32 flt32_val)
> {
> int fraction, shift, mantissa, sign, exp, zeropre;
>
> @@ -201,9 +201,9 @@ static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id,
> OFFSET_SENSOR_DATA_DEFAULT;
> memcpy_fromio(&accel_data, sensoraddr, sizeof(struct sfh_accel_data));
> get_common_inputs(&acc_input.common_property, report_id);
> - acc_input.in_accel_x_value = float_to_int(accel_data.acceldata.x) / 100;
> - acc_input.in_accel_y_value = float_to_int(accel_data.acceldata.y) / 100;
> - acc_input.in_accel_z_value = float_to_int(accel_data.acceldata.z) / 100;
> + acc_input.in_accel_x_value = amd_sfh_float_to_int(accel_data.acceldata.x) / 100;
> + acc_input.in_accel_y_value = amd_sfh_float_to_int(accel_data.acceldata.y) / 100;
> + acc_input.in_accel_z_value = amd_sfh_float_to_int(accel_data.acceldata.z) / 100;
> memcpy(input_report, &acc_input, sizeof(acc_input));
> report_size = sizeof(acc_input);
> break;
> @@ -212,9 +212,9 @@ static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id,
> OFFSET_SENSOR_DATA_DEFAULT;
> memcpy_fromio(&gyro_data, sensoraddr, sizeof(struct sfh_gyro_data));
> get_common_inputs(&gyro_input.common_property, report_id);
> - gyro_input.in_angel_x_value = float_to_int(gyro_data.gyrodata.x) / 1000;
> - gyro_input.in_angel_y_value = float_to_int(gyro_data.gyrodata.y) / 1000;
> - gyro_input.in_angel_z_value = float_to_int(gyro_data.gyrodata.z) / 1000;
> + gyro_input.in_angel_x_value = amd_sfh_float_to_int(gyro_data.gyrodata.x) / 1000;
> + gyro_input.in_angel_y_value = amd_sfh_float_to_int(gyro_data.gyrodata.y) / 1000;
> + gyro_input.in_angel_z_value = amd_sfh_float_to_int(gyro_data.gyrodata.z) / 1000;
> memcpy(input_report, &gyro_input, sizeof(gyro_input));
> report_size = sizeof(gyro_input);
> break;
> @@ -223,9 +223,9 @@ static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id,
> OFFSET_SENSOR_DATA_DEFAULT;
> memcpy_fromio(&mag_data, sensoraddr, sizeof(struct sfh_mag_data));
> get_common_inputs(&magno_input.common_property, report_id);
> - magno_input.in_magno_x = float_to_int(mag_data.magdata.x) / 100;
> - magno_input.in_magno_y = float_to_int(mag_data.magdata.y) / 100;
> - magno_input.in_magno_z = float_to_int(mag_data.magdata.z) / 100;
> + magno_input.in_magno_x = amd_sfh_float_to_int(mag_data.magdata.x) / 100;
> + magno_input.in_magno_y = amd_sfh_float_to_int(mag_data.magdata.y) / 100;
> + magno_input.in_magno_z = amd_sfh_float_to_int(mag_data.magdata.z) / 100;
> magno_input.in_magno_accuracy = mag_data.accuracy / 100;
> memcpy(input_report, &magno_input, sizeof(magno_input));
> report_size = sizeof(magno_input);
> @@ -235,13 +235,15 @@ static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id,
> OFFSET_SENSOR_DATA_DEFAULT;
> memcpy_fromio(&als_data, sensoraddr, sizeof(struct sfh_als_data));
> get_common_inputs(&als_input.common_property, report_id);
> - als_input.illuminance_value = float_to_int(als_data.lux);
> + als_input.illuminance_value = amd_sfh_float_to_int(als_data.lux);
>
> memcpy_fromio(&binfo, mp2->vsbase, sizeof(struct sfh_base_info));
> if (binfo.sbase.s_prop[ALS_IDX].sf.feat & 0x2) {
> als_input.light_color_temp = als_data.light_color_temp;
> - als_input.chromaticity_x_value = float_to_int(als_data.chromaticity_x);
> - als_input.chromaticity_y_value = float_to_int(als_data.chromaticity_y);
> + als_input.chromaticity_x_value =
> + amd_sfh_float_to_int(als_data.chromaticity_x);
> + als_input.chromaticity_y_value =
> + amd_sfh_float_to_int(als_data.chromaticity_y);
> }
>
> report_size = sizeof(als_input);
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h
> index 656c3e95ef8c..75267b0fec70 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h
> @@ -166,4 +166,5 @@ struct hpd_status {
>
> void sfh_interface_init(struct amd_mp2_dev *mp2);
> void amd_sfh1_1_set_desc_ops(struct amd_mp2_ops *mp2_ops);
> +int amd_sfh_float_to_int(u32 flt32_val);
> #endif
next prev parent reply other threads:[~2023-12-04 19:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 10:15 [PATCH v6 00/15] Introduce PMF Smart PC Solution Builder Feature Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 01/15] platform/x86/amd/pmf: Add PMF TEE interface Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 02/15] platform/x86/amd/pmf: Add support for PMF-TA interaction Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 03/15] platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr() Shyam Sundar S K
2023-12-11 8:40 ` Hans de Goede
2023-12-11 15:15 ` Shyam Sundar S K
2023-12-11 15:55 ` Hans de Goede
2023-12-11 16:35 ` Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary Shyam Sundar S K
2023-12-04 19:05 ` Mario Limonciello
2023-12-11 8:53 ` Hans de Goede
2023-12-04 10:15 ` [PATCH v6 05/15] platform/x86/amd/pmf: change amd_pmf_init_features() call sequence Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems Shyam Sundar S K
2023-12-04 19:03 ` Mario Limonciello
2023-12-04 10:15 ` [PATCH v6 07/15] platform/x86/amd/pmf: Add support update p3t limit Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 08/15] platform/x86/amd/pmf: Add support to update system state Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 09/15] platform/x86/amd/pmf: Make source_as_str() as non-static Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 10/15] platform/x86/amd/pmf: Add facility to dump TA inputs Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 11/15] platform/x86/amd/pmf: Add capability to sideload of policy binary Shyam Sundar S K
2023-12-11 8:59 ` Hans de Goede
2023-12-04 10:15 ` [PATCH v6 12/15] platform/x86/amd/pmf: dump policy binary data Shyam Sundar S K
2023-12-04 10:15 ` [PATCH v6 13/15] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int() Shyam Sundar S K
2023-12-04 19:02 ` Mario Limonciello [this message]
2023-12-04 10:15 ` [PATCH v6 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD Shyam Sundar S K
2023-12-04 19:02 ` Mario Limonciello
2023-12-11 9:07 ` Hans de Goede
2023-12-04 10:15 ` [PATCH v6 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS Shyam Sundar S K
2023-12-11 9:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba6ded1b-7132-4165-b6be-77211c014e08@amd.com \
--to=mario.limonciello@amd.com \
--cc=Patil.Reddy@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox