Re: [PATCH v6 12/16] tests: validate dmsetup result in test 128

[Kevin Wolf <kwolf@redhat.com>]

Am 13.05.2026 um 13:59 hat Daniel P. Berrangé geschrieben:
> The I/O test 128 uses 'dmsetup create' to create a device, optionally
> using sudo to elevate privileges.
> 
> This dmsetup command works in GitLab CI, however, the test then fails
> with a missing device name:
> 
>   1..1
>   # running raw 128
>   not ok raw 128
>   ----------------------------------- stderr -----------------------------------
>   --- /builds/berrange/qemu/tests/qemu-iotests/128.out
>   +++ /builds/berrange/qemu/build/scratch/raw-file-128/128.out.bad
>   @@ -1,5 +1,5 @@
>    QA output created by 128
> 
>    == reading from error device ==
>   -read failed: Input/output error
>   +qemu-io: can't open device /dev/mapper/eiodev16546: Could not open '/dev/mapper/eiodev16546': No such file or directory
>    *** done
> 
>   (test program exited with status code 1)
> 
> It is believed that this is due to the build env using a manually
> populated /dev, such that the device mapper node won't ever appear.
> It is not a race, since a test adding a sleep did not result in the
> device appearing.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

I wonder how much this test gets run at all then. Tests requiring
passwordless sudo probably aren't something that most people run
locally, and my idea with them was mostly that at least CI will run
them.

So while I don't disagree with your fix, I wonder if the test couldn't
be rewritten to work without dmsetup. Maybe the FUSE export could help?

Anyway, for now:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>