[PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[Xiaobo Liu]

Replace pr_warn!() with pr_warn_once!() in module_param::set_param() to
avoid flooding the kernel log when a null pointer is repeatedly passed.

The original code had a TODO comment noting that pr_warn_once should be
used once available. Since pr_warn_once!() is now available, switch to it
and update the comment accordingly.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
---
 rust/kernel/module_param.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index 6a8a7a875..fedb709fa 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy {
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        // `pr_warn_once` is already available, use it.
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
         return EINVAL.to_errno();
     }
 
-- 
2.34.1

[PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[Xiaobo Liu]

Replace pr_warn!() with pr_warn_once!() in module_param::set_param() to
avoid flooding the kernel log when a null pointer is repeatedly passed.

The original code had a TODO comment noting that pr_warn_once should be
used once available. Since pr_warn_once!() is now available, switch to it
and update the comment accordingly.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
---
 rust/kernel/module_param.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index 6a8a7a875..fedb709fa 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy {
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        // `pr_warn_once` is already available, use it.
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
         return EINVAL.to_errno();
     }
 
-- 
2.34.1

Re: [PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[Miguel Ojeda]

On Mon, May 18, 2026 at 3:41 PM Xiaobo Liu <cppcoffee@gmail.com> wrote:
>
> Replace pr_warn!() with pr_warn_once!() in module_param::set_param() to
> avoid flooding the kernel log when a null pointer is repeatedly passed.
>
> The original code had a TODO comment noting that pr_warn_once should be
> used once available. Since pr_warn_once!() is now available, switch to it
> and update the comment accordingly.
>
> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>

Isn't this

  https://lore.kernel.org/rust-for-linux/20260226120848.82891-3-adarshdas950@gmail.com/

and this:

  https://lore.kernel.org/rust-for-linux/20260427-params-pr-once-v1-1-3a8c64704cc4@kernel.org/

? Cc'ing the authors of both. I will reply in the second one too.

(Also, your email seems to have been sent twice to the list)

In any case, Sashiko is correct, this "time-based comment" is not very useful:

> +        // `pr_warn_once` is already available, use it.

Cheers,
Miguel

[PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[Xiaobo Liu]

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
---
 rust/kernel/module_param.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
index 6a8a7a875..fedb709fa 100644
--- a/rust/kernel/module_param.rs
+++ b/rust/kernel/module_param.rs
@@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy {
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        // TODO: Use pr_warn_once available.
-        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
         return EINVAL.to_errno();
     }
 
-- 
2.34.1

Re: [PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once

[Onur Özkan]

On Mon, 18 May 2026 18:47:35 +0800
Xiaobo Liu <cppcoffee@gmail.com> wrote:

> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
> ---

You need to write description for the change.

Onur

>  rust/kernel/module_param.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
> index 6a8a7a875..fedb709fa 100644
> --- a/rust/kernel/module_param.rs
> +++ b/rust/kernel/module_param.rs
> @@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy {
>      // NOTE: If we start supporting arguments without values, val _is_ allowed
>      // to be null here.
>      if val.is_null() {
> -        // TODO: Use pr_warn_once available.
> -        crate::pr_warn!("Null pointer passed to `module_param::set_param`");
> +        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
>          return EINVAL.to_errno();
>      }
>  
> -- 
> 2.34.1
>