Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Kamal Mostafa <kamal@canonical.com>
To: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>,
	Felipe Balbi <balbi@ti.com>
Cc: stable@vger.kernel.org, kernel-team <kernel-team@lists.ubuntu.com>
Subject: usb: dwc3: DEPCMD/DGCMD patches for stable
Date: Wed, 15 Jul 2015 10:02:08 -0700	[thread overview]
Message-ID: <1436979728.32241.9.camel@fourier> (raw)

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi Felipe and Subbaraya-

I understand that you'd like us to hold off on applying these two to the
stable kernels:

  usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros
  usb: dwc3: gadget: return error if command sent to DEPCMD register fails

What about this one then?:

  891b1dc022955d36cf4c0f42d383226a930db7ed 
  usb: dwc3: gadget: return error if command sent to DGCMD register fails

Okay to apply that one to stable, or hold it also?

 -Kamal


[-- Attachment #2: 0001-usb-dwc3-gadget-return-error-if-command-sent-to-DGCM.patch --]
[-- Type: text/x-patch, Size: 1077 bytes --]

>From 891b1dc022955d36cf4c0f42d383226a930db7ed Mon Sep 17 00:00:00 2001
From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Date: Thu, 21 May 2015 15:46:47 +0530
Subject: usb: dwc3: gadget: return error if command sent to DGCMD register
 fails

We need to return error to caller if command is not sent to
controller succesfully.

Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Fixes: b09bb64239c8 (usb: dwc3: gadget: implement Global Command support)
Cc: <stable@vger.kernel.org> #v3.5+
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/dwc3/gadget.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 8946c32..fcbe120 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param)
 			dwc3_trace(trace_dwc3_gadget,
 					"Command Complete --> %d",
 					DWC3_DGCMD_STATUS(reg));
+			if (DWC3_DGCMD_STATUS(reg))
+				return -EINVAL;
 			return 0;
 		}
 
-- 
1.9.1


             reply	other threads:[~2015-07-15 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 17:02 Kamal Mostafa [this message]
2015-07-16  2:48 ` dwc3: DEPCMD/DGCMD patches for stable Subbaraya Sundeep Bhatta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436979728.32241.9.camel@fourier \
    --to=kamal@canonical.com \
    --cc=balbi@ti.com \
    --cc=kernel-team@lists.ubuntu.com \
    --cc=stable@vger.kernel.org \
    --cc=subbaraya.sundeep.bhatta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox