usb: dwc3: DEPCMD/DGCMD patches for stable

usb: dwc3: DEPCMD/DGCMD patches for stable

[Kamal Mostafa]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi Felipe and Subbaraya-

I understand that you'd like us to hold off on applying these two to the
stable kernels:

  usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros
  usb: dwc3: gadget: return error if command sent to DEPCMD register fails

What about this one then?:

  891b1dc022955d36cf4c0f42d383226a930db7ed 
  usb: dwc3: gadget: return error if command sent to DGCMD register fails

Okay to apply that one to stable, or hold it also?

 -Kamal


[-- Attachment #2: 0001-usb-dwc3-gadget-return-error-if-command-sent-to-DGCM.patch --]
[-- Type: text/x-patch, Size: 1077 bytes --]

>From 891b1dc022955d36cf4c0f42d383226a930db7ed Mon Sep 17 00:00:00 2001
From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Date: Thu, 21 May 2015 15:46:47 +0530
Subject: usb: dwc3: gadget: return error if command sent to DGCMD register
 fails

We need to return error to caller if command is not sent to
controller succesfully.

Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Fixes: b09bb64239c8 (usb: dwc3: gadget: implement Global Command support)
Cc: <stable@vger.kernel.org> #v3.5+
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/dwc3/gadget.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 8946c32..fcbe120 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param)
 			dwc3_trace(trace_dwc3_gadget,
 					"Command Complete --> %d",
 					DWC3_DGCMD_STATUS(reg));
+			if (DWC3_DGCMD_STATUS(reg))
+				return -EINVAL;
 			return 0;
 		}
 
-- 
1.9.1

RE: dwc3: DEPCMD/DGCMD patches for stable

[Subbaraya Sundeep Bhatta]

Hi Kamal,

> -----Original Message-----
> From: Kamal Mostafa [mailto:kamal@canonical.com]
> Sent: Wednesday, July 15, 2015 10:32 PM
> To: Subbaraya Sundeep Bhatta; Felipe Balbi
> Cc: stable@vger.kernel.org; kernel-team
> Subject: usb: dwc3: DEPCMD/DGCMD patches for stable
>
> Hi Felipe and Subbaraya-
>
> I understand that you'd like us to hold off on applying these two to the
> stable kernels:
>
>   usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros

This patch can be applied. No functional changes only corrected wrong bit masks.

>   usb: dwc3: gadget: return error if command sent to DEPCMD register fails

Please hold on this.
>
> What about this one then?:
>
>   891b1dc022955d36cf4c0f42d383226a930db7ed
>   usb: dwc3: gadget: return error if command sent to DGCMD register fails

This one Felipe can answer because am really not sure how this is used (still learning DWC3 :)).
But this did not cause any regression issues. Felipe is on vacation. We will hear from him after July-18.

Thanks,
Sundeep

>
> Okay to apply that one to stable, or hold it also?
>
>  -Kamal



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.