Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Amit Pundir <amit.pundir@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>, Stable <stable@vger.kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: [PATCH for-4.9.y 1/5] mtd: m25p80: consider max message size in m25p80_read
Date: Tue, 17 Jul 2018 13:49:14 +0530	[thread overview]
Message-ID: <1531815558-20002-2-git-send-email-amit.pundir@linaro.org> (raw)
In-Reply-To: <1531815558-20002-1-git-send-email-amit.pundir@linaro.org>

From: Heiner Kallweit <hkallweit1@gmail.com>

commit 9e276de6a367cde07c1a63522152985d4e5cca8b upstream.

Consider a message size limit when calculating the maximum amount
of data that can be read.

The message size limit has been introduced with 4.9, so cc it
to stable.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
Cherry-picked from lede tree https://git.lede-project.org/?p=source.git

 drivers/mtd/devices/m25p80.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 9cf7fcd28034..16a7df2a0246 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -172,7 +172,8 @@ static ssize_t m25p80_read(struct spi_nor *nor, loff_t from, size_t len,
 
 	t[1].rx_buf = buf;
 	t[1].rx_nbits = m25p80_rx_nbits(nor);
-	t[1].len = min(len, spi_max_transfer_size(spi));
+	t[1].len = min3(len, spi_max_transfer_size(spi),
+			spi_max_message_size(spi) - t[0].len);
 	spi_message_add_tail(&t[1], &m);
 
 	ret = spi_sync(spi, &m);
-- 
2.7.4

  reply	other threads:[~2018-07-17  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17  8:19 [PATCH for-4.9.y 0/5] Stable commits picked up from lede project Amit Pundir
2018-07-17  8:19 ` Amit Pundir [this message]
2018-07-17  8:19 ` [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits Amit Pundir
2018-07-18 10:47   ` Mark Brown
2018-07-18 10:55     ` Greg KH
2018-07-18 11:14       ` Mark Brown
2018-07-17  8:19 ` [PATCH for-4.9.y 3/5] spi/bcm63xx: fix typo in bcm63xx_spi_max_length breaking compilation Amit Pundir
2018-07-17  8:19 ` [PATCH for-4.9.y 4/5] bcm63xx_enet: correct clock usage Amit Pundir
2018-07-17  8:19 ` [PATCH for-4.9.y 5/5] bcm63xx_enet: do not write to random DMA channel on BCM6345 Amit Pundir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531815558-20002-2-git-send-email-amit.pundir@linaro.org \
    --to=amit.pundir@linaro.org \
    --cc=cyrille.pitchen@atmel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox