From: Mark Brown <broonie@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Amit Pundir <amit.pundir@linaro.org>,
Stable <stable@vger.kernel.org>,
Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits
Date: Wed, 18 Jul 2018 12:14:31 +0100 [thread overview]
Message-ID: <20180718111431.GG5700@sirena.org.uk> (raw)
In-Reply-To: <20180718105546.GA29375@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Wed, Jul 18, 2018 at 12:55:46PM +0200, Greg KH wrote:
> On Wed, Jul 18, 2018 at 11:47:18AM +0100, Mark Brown wrote:
> > On Tue, Jul 17, 2018 at 01:49:15PM +0530, Amit Pundir wrote:
> > > The bcm63xx SPI controller does not allow manual control of the CS
> > > lines and will toggle it automatically before and after sending data,
> > > so we are limited to messages that fit in the FIFO buffer. Since the CS
> > > lines aren't available as GPIOs either, we will need to make slave
> > > drivers aware of this limitation so they can handle them accordingly.
> > This seems a bit new featureish...
> It is? Reads like a bugfix to me to get crappy hardware to work
> properly :)
> Almost like a quirk addition.
Yes, it is a quirk addition.
> Anyway, it's a 9 line patch that the users of the hardware require to
> get it to work, is it a problem to add?
It's one of these cases where if someone notices the change it's because
it causes the consumer driver to exercise code paths that they weren't
otherwise exercising (for a little used feature too). If it were just
in the driver perhaps but the actual use of the change would be in other
code which makes it more risky.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-18 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 8:19 [PATCH for-4.9.y 0/5] Stable commits picked up from lede project Amit Pundir
2018-07-17 8:19 ` [PATCH for-4.9.y 1/5] mtd: m25p80: consider max message size in m25p80_read Amit Pundir
2018-07-17 8:19 ` [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits Amit Pundir
2018-07-18 10:47 ` Mark Brown
2018-07-18 10:55 ` Greg KH
2018-07-18 11:14 ` Mark Brown [this message]
2018-07-17 8:19 ` [PATCH for-4.9.y 3/5] spi/bcm63xx: fix typo in bcm63xx_spi_max_length breaking compilation Amit Pundir
2018-07-17 8:19 ` [PATCH for-4.9.y 4/5] bcm63xx_enet: correct clock usage Amit Pundir
2018-07-17 8:19 ` [PATCH for-4.9.y 5/5] bcm63xx_enet: do not write to random DMA channel on BCM6345 Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718111431.GG5700@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.gorski@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).