* [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX
@ 2018-09-21 14:07 kan.liang
2018-09-21 14:14 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: kan.liang @ 2018-09-21 14:07 UTC (permalink / raw)
To: tglx, peterz, mingo, linux-kernel; +Cc: ak, eranian, stable, Kan Liang
From: Kan Liang <kan.liang@linux.intel.com>
The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
these counters may causes system crash on some machines.
The PCI BDF addresses of M3UPI in current code are incorrect.
The correct addresses should be
D18:F1 0x204D
D18:F2 0x204E
D18:F5 0x204D
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
arch/x86/events/intel/uncore_snbep.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 51d7c11..3b3fc92 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3931,16 +3931,16 @@ static const struct pci_device_id skx_uncore_pci_ids[] = {
.driver_data = UNCORE_PCI_DEV_FULL_DATA(21, 5, SKX_PCI_UNCORE_M2PCIE, 3),
},
{ /* M3UPI0 Link 0 */
- PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204C),
- .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 0, SKX_PCI_UNCORE_M3UPI, 0),
+ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D),
+ .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 1, SKX_PCI_UNCORE_M3UPI, 0),
},
{ /* M3UPI0 Link 1 */
- PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D),
- .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 1, SKX_PCI_UNCORE_M3UPI, 1),
+ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204E),
+ .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 2, SKX_PCI_UNCORE_M3UPI, 1),
},
{ /* M3UPI1 Link 2 */
- PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204C),
- .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 4, SKX_PCI_UNCORE_M3UPI, 2),
+ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x204D),
+ .driver_data = UNCORE_PCI_DEV_FULL_DATA(18, 5, SKX_PCI_UNCORE_M3UPI, 2),
},
{ /* end: all zeroes */ }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX
2018-09-21 14:07 [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX kan.liang
@ 2018-09-21 14:14 ` Peter Zijlstra
2018-09-21 14:37 ` Liang, Kan
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2018-09-21 14:14 UTC (permalink / raw)
To: kan.liang; +Cc: tglx, mingo, linux-kernel, ak, eranian, stable
On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
> these counters may causes system crash on some machines.
>
> The PCI BDF addresses of M3UPI in current code are incorrect.
> The correct addresses should be
> D18:F1 0x204D
> D18:F2 0x204E
> D18:F5 0x204D
Should this have a Fixes: tag?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX
2018-09-21 14:14 ` Peter Zijlstra
@ 2018-09-21 14:37 ` Liang, Kan
0 siblings, 0 replies; 3+ messages in thread
From: Liang, Kan @ 2018-09-21 14:37 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: tglx, mingo, linux-kernel, ak, eranian, stable
On 9/21/2018 10:14 AM, Peter Zijlstra wrote:
> On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
>> these counters may causes system crash on some machines.
>>
>> The PCI BDF addresses of M3UPI in current code are incorrect.
>> The correct addresses should be
>> D18:F1 0x204D
>> D18:F2 0x204E
>> D18:F5 0x204D
>
> Should this have a Fixes: tag?
>
Yes, sorry for missing it.
Here it is.
Fixes: cd34cd97b7b4 ("perf/x86/intel/uncore: Add Skylake server uncore
support")
Thanks,
Kan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 14:07 [PATCH] perf/x86/intel/uncore: Fix PCI BDF address of M3UPI on SKX kan.liang
2018-09-21 14:14 ` Peter Zijlstra
2018-09-21 14:37 ` Liang, Kan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox