Linux kernel -stable discussions
 help / color / mirror / Atom feed
* [patch 1/2] clk: spear3xx: Use proper control register offset
       [not found] <20140619214858.755664030@linutronix.de>
@ 2014-06-19 21:52 ` Thomas Gleixner
  2014-06-20  4:51   ` Viresh Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2014-06-19 21:52 UTC (permalink / raw)
  To: LKML; +Cc: Viresh Kumar, Mike Turquette, spear-devel, stable

[-- Attachment #1: spear-clk-fix-crap.patch --]
[-- Type: text/plain, Size: 877 bytes --]

The control register is at offset 0x10, not 0x0. This is wreckaged
since commit 5df33a62c (SPEAr: Switch to common clock framework).

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
---
 drivers/clk/spear/spear3xx_clock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/clk/spear/spear3xx_clock.c
===================================================================
--- linux.orig/drivers/clk/spear/spear3xx_clock.c
+++ linux/drivers/clk/spear/spear3xx_clock.c
@@ -211,7 +211,7 @@ static inline void spear310_clk_init(voi
 /* array of all spear 320 clock lookups */
 #ifdef CONFIG_MACH_SPEAR320
 
-#define SPEAR320_CONTROL_REG		(soc_config_base + 0x0000)
+#define SPEAR320_CONTROL_REG		(soc_config_base + 0x0010)
 #define SPEAR320_EXT_CTRL_REG		(soc_config_base + 0x0018)
 
 	#define SPEAR320_UARTX_PCLK_MASK		0x1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/2] clk: spear3xx: Use proper control register offset
  2014-06-19 21:52 ` [patch 1/2] clk: spear3xx: Use proper control register offset Thomas Gleixner
@ 2014-06-20  4:51   ` Viresh Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2014-06-20  4:51 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Mike Turquette, spear-devel, stable

On Fri, Jun 20, 2014 at 3:22 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> The control register is at offset 0x10, not 0x0. This is wreckaged
> since commit 5df33a62c (SPEAr: Switch to common clock framework).
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
> ---
>  drivers/clk/spear/spear3xx_clock.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/clk/spear/spear3xx_clock.c
> ===================================================================
> --- linux.orig/drivers/clk/spear/spear3xx_clock.c
> +++ linux/drivers/clk/spear/spear3xx_clock.c
> @@ -211,7 +211,7 @@ static inline void spear310_clk_init(voi
>  /* array of all spear 320 clock lookups */
>  #ifdef CONFIG_MACH_SPEAR320
>
> -#define SPEAR320_CONTROL_REG           (soc_config_base + 0x0000)
> +#define SPEAR320_CONTROL_REG           (soc_config_base + 0x0010)
>  #define SPEAR320_EXT_CTRL_REG          (soc_config_base + 0x0018)
>
>         #define SPEAR320_UARTX_PCLK_MASK                0x1

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-20  4:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20140619214858.755664030@linutronix.de>
2014-06-19 21:52 ` [patch 1/2] clk: spear3xx: Use proper control register offset Thomas Gleixner
2014-06-20  4:51   ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox