* [PATCH for v4.4] ovl: copy new uid/gid into overlayfs runtime inode
@ 2016-03-12 13:03 Miklos Szeredi
0 siblings, 0 replies; only message in thread
From: Miklos Szeredi @ 2016-03-12 13:03 UTC (permalink / raw)
To: stable; +Cc: koct9i
From: Konstantin Khlebnikov <koct9i@gmail.com>
Date: Sun, 31 Jan 2016 16:21:29 +0300
commit b81de061fa59f17d2730aabb1b84419ef3913810 upstream.
Overlayfs must update uid/gid after chown, otherwise functions
like inode_owner_or_capable() will check user against stale uid.
Catched by xfstests generic/087, it chowns file and calls utimes.
Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Cc: <stable@vger.kernel.org>
---
fs/overlayfs/inode.c | 2 ++
1 file changed, 2 insertions(+)
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -52,6 +52,8 @@ int ovl_setattr(struct dentry *dentry, s
mutex_lock(&upperdentry->d_inode->i_mutex);
err = notify_change(upperdentry, attr, NULL);
+ if (!err)
+ ovl_copyattr(upperdentry->d_inode, dentry->d_inode);
mutex_unlock(&upperdentry->d_inode->i_mutex);
}
ovl_drop_write(dentry);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-03-12 13:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-12 13:03 [PATCH for v4.4] ovl: copy new uid/gid into overlayfs runtime inode Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox