From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>, Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting
Date: Sat, 2 Feb 2019 12:31:43 +0100 [thread overview]
Message-ID: <20190202113143.GD31341@kroah.com> (raw)
In-Reply-To: <CAKywueS2bXX_DNTYnSJAgSCaND8u=07JkViYTr5g+yX-bC6isQ@mail.gmail.com>
On Fri, Feb 01, 2019 at 12:17:21PM -0800, Pavel Shilovsky wrote:
> пт, 1 февр. 2019 г. в 06:11, Sasha Levin <sashal@kernel.org>:
> >
> > On Thu, Jan 31, 2019 at 10:37:54AM -0800, Pavel Shilovsky wrote:
> > >ср, 30 янв. 2019 г. в 23:16, Greg KH <gregkh@linuxfoundation.org>:
> > >>
> > >> On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote:
> > >> > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting").
> > >> >
> > >> > In case a hostname resolves to a different IP address (e.g. long
> > >> > running mounts), make sure to resolve it every time prior to calling
> > >> > generic_ip_connect() in reconnect.
> > >> >
> > >> > This patch needs user space changes of cifs.upcall that set a timeout
> > >> > value for the "dns_resolver" key.
> > >> >
> > >> > Suggested-by: Steve French <stfrench@microsoft.com>
> > >> > Signed-off-by: Paulo Alcantara <palcantara@suse.de>
> > >> > Signed-off-by: Steve French <stfrench@microsoft.com>
> > >> > Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
> > >> > ---
> > >> > fs/cifs/connect.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >> > 1 file changed, 53 insertions(+)
> > >>
> > >> What stable kernel(s) is this to be applied to?
> > >>\
> > >
> > >All stable kernels that are under active maintenance may have the fix
> > >if it applies clearly. Please let me know if it doesn't.
> >
> > So this wasn't actually tested against any of the stable kernels? Why
> > not? Microsoft has a solid testsuite for it.
>
> This was successfully tested on v4.4.y kernel.
That's odd, as you generated this diff against the 4.20.y kernel.
Oh well, I'll go queue this up, to all of the kernel trees, but be
careful...
greg k-h
next prev parent reply other threads:[~2019-02-02 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 0:07 [PATCH] cifs: Always resolve hostname before reconnecting Pavel Shilovsky
2019-01-31 7:16 ` Greg KH
2019-01-31 18:37 ` Pavel Shilovsky
2019-02-01 14:11 ` Sasha Levin
2019-02-01 20:17 ` Pavel Shilovsky
2019-02-02 11:31 ` Greg KH [this message]
2019-02-02 11:33 ` Greg KH
2019-02-02 18:13 ` Pavel Shilovsky
2019-02-02 18:17 ` Pavel Shilovsky
2019-02-02 20:30 ` Steve French
2019-02-04 8:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202113143.GD31341@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=piastryyy@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox