From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting
Date: Sat, 2 Feb 2019 12:33:17 +0100 [thread overview]
Message-ID: <20190202113317.GE31341@kroah.com> (raw)
In-Reply-To: <1548893250-48583-1-git-send-email-pshilov@microsoft.com>
On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote:
> Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting").
>
> In case a hostname resolves to a different IP address (e.g. long
> running mounts), make sure to resolve it every time prior to calling
> generic_ip_connect() in reconnect.
>
> This patch needs user space changes of cifs.upcall that set a timeout
> value for the "dns_resolver" key.
Wait, you are requiring userspace to upgrade tools to support this? And
you think that will happen to all systems running older kernels?
This really feels like a new feature being added, what bug is this
fixing that requires it to be backported to all of the stable kernel
trees?
>
> Suggested-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Paulo Alcantara <palcantara@suse.de>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
At the very least, I would like the CIFS maintainer to ack this type of
thing before accepting it, as it was not tagged for the stable kernels
for some reason...
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-02 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 0:07 [PATCH] cifs: Always resolve hostname before reconnecting Pavel Shilovsky
2019-01-31 7:16 ` Greg KH
2019-01-31 18:37 ` Pavel Shilovsky
2019-02-01 14:11 ` Sasha Levin
2019-02-01 20:17 ` Pavel Shilovsky
2019-02-02 11:31 ` Greg KH
2019-02-02 11:33 ` Greg KH [this message]
2019-02-02 18:13 ` Pavel Shilovsky
2019-02-02 18:17 ` Pavel Shilovsky
2019-02-02 20:30 ` Steve French
2019-02-04 8:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202113317.GE31341@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=piastryyy@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox