[4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")

[4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")

[Taras Kondratiuk]

Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
patch has a few follow up fixes in upstream that also have to be applied
to 4.4:
d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2

The first patch should fix v4.4.156 regression reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=201633.

Rest of stable kernels (4.9+) already have these followup fixes.

Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")

[Sasha Levin]

On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
>Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
>the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
>patch has a few follow up fixes in upstream that also have to be applied
>to 4.4:
>d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
>8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2

The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
and 51f8f3c4e225.

I've queued up d0e13f5bbe4b for 4.4.

--
Thanks,
Sasha

Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")

[Taras Kondratiuk]

Quoting Sasha Levin (2019-04-18 06:46:12)
> On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
> >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
> >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
> >patch has a few follow up fixes in upstream that also have to be applied
> >to 4.4:
> >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
> >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
> 
> The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
> and 51f8f3c4e225.

The context is slightly modified by 51f8f3c4e225, but it looks
irrelevant. The fix should be still valid, because err value can be set
to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super()
will return a random value of mnt pointer instead of a proper error
code.

> 
> I've queued up d0e13f5bbe4b for 4.4.

Thanks.

Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")

[Greg KH]

On Thu, Apr 18, 2019 at 11:19:32AM -0700, Taras Kondratiuk wrote:
> Quoting Sasha Levin (2019-04-18 06:46:12)
> > On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
> > >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
> > >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
> > >patch has a few follow up fixes in upstream that also have to be applied
> > >to 4.4:
> > >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
> > >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
> > 
> > The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
> > and 51f8f3c4e225.
> 
> The context is slightly modified by 51f8f3c4e225, but it looks
> irrelevant. The fix should be still valid, because err value can be set
> to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super()
> will return a random value of mnt pointer instead of a proper error
> code.

Can you provide a working backport please, so that it can be applied?

thanks,

greg k-h