queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

[Wang Yugui]

Hi,

drop perf-stat-display-event-stats-using-aggr-counts.patch
from queue-6.1 please.

It failed to compile on 6.1.y now.

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2022/12/27

Re: queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

[Greg KH]

On Tue, Dec 27, 2022 at 08:25:45AM +0800, Wang Yugui wrote:
> Hi,
> 
> drop perf-stat-display-event-stats-using-aggr-counts.patch
> from queue-6.1 please.
> 
> It failed to compile on 6.1.y now.

Why not just also queue up b89761351089 ("perf stat: Update event skip
condition for system-wide per-thread mode and merged uncore and hybrid
events")?

thanks,

greg k-h

Re: queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

[Wang Yugui]

Hi,

> On Tue, Dec 27, 2022 at 08:25:45AM +0800, Wang Yugui wrote:
> > Hi,
> > 
> > drop perf-stat-display-event-stats-using-aggr-counts.patch
> > from queue-6.1 please.
> > 
> > It failed to compile on 6.1.y now.
> 
> Why not just also queue up b89761351089 ("perf stat: Update event skip
> condition for system-wide per-thread mode and merged uncore and hybrid
> events")?

We could add 
ca68b374d040 (perf stat: Add struct perf_stat_aggr to perf_stat_evsel)

to queue-6.1 before the patch 'perf-stat-display-event-stats-using-aggr-counts.patch'

to fix the build error.
util/stat-display.c: In function 'print_counter_aggrdata':
util/stat-display.c:690:35: error: 'struct perf_stat_evsel' has no member named 'aggr'
  struct perf_stat_aggr *aggr = &ps->aggr[s];

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2022/12/27

> thanks,
> 
> greg k-h

Re: queue-6.1 drop perf-stat-display-event-stats-using-aggr-counts.patch please

[Greg KH]

On Tue, Dec 27, 2022 at 05:27:43PM +0800, Wang Yugui wrote:
> Hi,
> 
> > On Tue, Dec 27, 2022 at 08:25:45AM +0800, Wang Yugui wrote:
> > > Hi,
> > > 
> > > drop perf-stat-display-event-stats-using-aggr-counts.patch
> > > from queue-6.1 please.
> > > 
> > > It failed to compile on 6.1.y now.
> > 
> > Why not just also queue up b89761351089 ("perf stat: Update event skip
> > condition for system-wide per-thread mode and merged uncore and hybrid
> > events")?
> 
> We could add 
> ca68b374d040 (perf stat: Add struct perf_stat_aggr to perf_stat_evsel)
> 
> to queue-6.1 before the patch 'perf-stat-display-event-stats-using-aggr-counts.patch'
> 
> to fix the build error.
> util/stat-display.c: In function 'print_counter_aggrdata':
> util/stat-display.c:690:35: error: 'struct perf_stat_evsel' has no member named 'aggr'
>   struct perf_stat_aggr *aggr = &ps->aggr[s];

Ok, that got messy fast, as things didn't apply.

I've dropped the original commit here now, can you send a backported
series to us for inclusion in 6.1 that will work properly?

thanks,

greg k-h