Build failures / crashes in stable queue branches

Build failures / crashes in stable queue branches

[Guenter Roeck]

4.14.y:

Build reference: v4.14.320-57-gbc1094b21392
Compiler version: arm-linux-gnueabi-gcc (GCC) 11.4.0
Assembler version: GNU assembler (GNU Binutils) 2.40

Building arm:omap2plus_defconfig ... failed
Building arm:multi_v5_defconfig ... failed
Building arm:keystone_defconfig ... failed (and others)

arm-linux-gnueabi-ld: arch/arm/probes/kprobes/core.o: in function `jprobe_return':
arch/arm/probes/kprobes/core.c:555: undefined reference to `kprobe_handler'

---------
6.1.y:

Build reference: v6.1.38-393-gb6386e7314b4
Compiler version: alpha-linux-gcc (GCC) 11.4.0
Assembler version: GNU assembler (GNU Binutils) 2.40

Building alpha:allmodconfig ... failed
Building m68k:allmodconfig ... failed
--------------
Error log:
<stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
In file included from block/genhd.c:28:
block/genhd.c: In function 'disk_release':
include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
    88 | # define blk_trace_remove(q)                            (-ENOTTY)
       |                                                         ^
block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
  1185 |         blk_trace_remove(disk->queue);

-------------
6.4.y:

Build reference: v6.4.3-548-g5f35ab2efbc9
Compiler version: alpha-linux-gcc (GCC) 11.4.0
Assembler version: GNU assembler (GNU Binutils) 2.40

Building alpha:allmodconfig ... failed
Building m68k:allmodconfig ... failed
--------------
Error log:
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
In file included from block/genhd.c:28:
block/genhd.c: In function 'disk_release':
include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
    88 | # define blk_trace_remove(q)                            (-ENOTTY)
       |                                                         ^
block/genhd.c:1175:9: note: in expansion of macro 'blk_trace_remove'
  1175 |         blk_trace_remove(disk->queue);

Building mips:allmodconfig ... failed
--------------
Error log:
arch/mips/boot/dts/ingenic/ci20.dts:242.19-247.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC1: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:248.18-253.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC2: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:254.18-259.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC3: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:265.17-270.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO5: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:271.18-276.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO6: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:277.20-282.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO7: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:283.20-288.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO8: Reference to non-existent node or label "vcc_33v"
ERROR: Input tree has errors, aborting (use -f to force output)
make[3]: [scripts/Makefile.lib:419: arch/mips/boot/dts/ingenic/ci20.dtb] Error 2 (ignored)
arch/mips/boot/dts/ingenic/ci20.dts:242.19-247.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC1: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:248.18-253.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC2: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:254.18-259.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC3: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:265.17-270.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO5: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:271.18-276.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO6: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:277.20-282.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO7: Reference to non-existent node or label "vcc_33v"
arch/mips/boot/dts/ingenic/ci20.dts:283.20-288.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO8: Reference to non-existent node or label "vcc_33v"
ERROR: Input tree has errors, aborting (use -f to force output)

On top of the build failures, mcimx7d-sabre emulations crash
in 6.4.y.queue with a NULL pointer access in ads7846_probe().

[   15.286830] 8<--- cut here ---
[   15.287438] Unhandled fault: page domain fault (0x01b) at 0x00001eba
[   15.287707] [00001eba] *pgd=00000000
[   15.288503] Internal error: : 1b [#1] SMP ARM
[   15.288852] Modules linked in:
[   15.289177] CPU: 0 PID: 29 Comm: kworker/u4:2 Tainted: G                 N 6.4.4-rc1-g5f35ab2efbc9 #1
[   15.289433] Hardware name: Freescale i.MX7 Dual (Device Tree)
[   15.289780] Workqueue: events_unbound deferred_probe_work_func
[   15.290540] PC is at ads7846_probe+0x9f0/0xfa0
[   15.290701] LR is at _raw_spin_unlock_irqrestore+0x50/0x64

That is due to it picking up "Input: ads7846 - Convert to use software nodes"
without its fixes.

Guenter

Re: Build failures / crashes in stable queue branches

[Joel Fernandes]

Hi Yu,

On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
[..]
> ---------
> 6.1.y:
> 
> Build reference: v6.1.38-393-gb6386e7314b4
> Compiler version: alpha-linux-gcc (GCC) 11.4.0
> Assembler version: GNU assembler (GNU Binutils) 2.40
> 
> Building alpha:allmodconfig ... failed
> Building m68k:allmodconfig ... failed
> --------------
> Error log:
> <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> In file included from block/genhd.c:28:
> block/genhd.c: In function 'disk_release':
> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>    88 | # define blk_trace_remove(q)                            (-ENOTTY)
>       |                                                         ^
> block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
>  1185 |         blk_trace_remove(disk->queue);

6.1 stable is broken and gives build warning without:

cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")

Could you please submit it to stable for 6.1? (I could have done that but it
looks like you already backported related patches so its best for you to do
it, thanks for your help!).

thanks,

 - Joel

Re: Build failures / crashes in stable queue branches

[Yu Kuai]

Hi,

在 2023/07/15 23:49, Joel Fernandes 写道:
> Hi Yu,
> 
> On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> [..]
>> ---------
>> 6.1.y:
>>
>> Build reference: v6.1.38-393-gb6386e7314b4
>> Compiler version: alpha-linux-gcc (GCC) 11.4.0
>> Assembler version: GNU assembler (GNU Binutils) 2.40
>>
>> Building alpha:allmodconfig ... failed
>> Building m68k:allmodconfig ... failed
>> --------------
>> Error log:
>> <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> In file included from block/genhd.c:28:
>> block/genhd.c: In function 'disk_release':
>> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>>     88 | # define blk_trace_remove(q)                            (-ENOTTY)
>>        |                                                         ^
>> block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
>>   1185 |         blk_trace_remove(disk->queue);
> 
> 6.1 stable is broken and gives build warning without:
> 
> cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
> 
> Could you please submit it to stable for 6.1? (I could have done that but it
> looks like you already backported related patches so its best for you to do
> it, thanks for your help!).

Thanks for the notice, however, I'll suggest to revert this patch for
now, because there are follow up fixes that is not applied yet.

Kuai
> 
> thanks,
> 
>   - Joel
> 
> .
> 

Re: Build failures / crashes in stable queue branches

[Greg KH]

On Sat, Jul 15, 2023 at 03:49:23PM +0000, Joel Fernandes wrote:
> Hi Yu,
> 
> On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> [..]
> > ---------
> > 6.1.y:
> > 
> > Build reference: v6.1.38-393-gb6386e7314b4
> > Compiler version: alpha-linux-gcc (GCC) 11.4.0
> > Assembler version: GNU assembler (GNU Binutils) 2.40
> > 
> > Building alpha:allmodconfig ... failed
> > Building m68k:allmodconfig ... failed
> > --------------
> > Error log:
> > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > In file included from block/genhd.c:28:
> > block/genhd.c: In function 'disk_release':
> > include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
> >    88 | # define blk_trace_remove(q)                            (-ENOTTY)
> >       |                                                         ^
> > block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
> >  1185 |         blk_trace_remove(disk->queue);
> 
> 6.1 stable is broken and gives build warning without:
> 
> cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
> 
> Could you please submit it to stable for 6.1? (I could have done that but it
> looks like you already backported related patches so its best for you to do
> it, thanks for your help!).

Now queued up, thanks.

greg k-h

Re: Build failures / crashes in stable queue branches

[Greg KH]

On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
> Hi,
> 
> 在 2023/07/15 23:49, Joel Fernandes 写道:
> > Hi Yu,
> > 
> > On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> > [..]
> > > ---------
> > > 6.1.y:
> > > 
> > > Build reference: v6.1.38-393-gb6386e7314b4
> > > Compiler version: alpha-linux-gcc (GCC) 11.4.0
> > > Assembler version: GNU assembler (GNU Binutils) 2.40
> > > 
> > > Building alpha:allmodconfig ... failed
> > > Building m68k:allmodconfig ... failed
> > > --------------
> > > Error log:
> > > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > In file included from block/genhd.c:28:
> > > block/genhd.c: In function 'disk_release':
> > > include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
> > >     88 | # define blk_trace_remove(q)                            (-ENOTTY)
> > >        |                                                         ^
> > > block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
> > >   1185 |         blk_trace_remove(disk->queue);
> > 
> > 6.1 stable is broken and gives build warning without:
> > 
> > cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
> > 
> > Could you please submit it to stable for 6.1? (I could have done that but it
> > looks like you already backported related patches so its best for you to do
> > it, thanks for your help!).
> 
> Thanks for the notice, however, I'll suggest to revert this patch for
> now, because there are follow up fixes that is not applied yet.

Which specific patch should be dropped?

thanks,

greg k-h

Re: Build failures / crashes in stable queue branches

[Greg KH]

On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> 4.14.y:
> 
> Build reference: v4.14.320-57-gbc1094b21392
> Compiler version: arm-linux-gnueabi-gcc (GCC) 11.4.0
> Assembler version: GNU assembler (GNU Binutils) 2.40
> 
> Building arm:omap2plus_defconfig ... failed
> Building arm:multi_v5_defconfig ... failed
> Building arm:keystone_defconfig ... failed (and others)
> 
> arm-linux-gnueabi-ld: arch/arm/probes/kprobes/core.o: in function `jprobe_return':
> arch/arm/probes/kprobes/core.c:555: undefined reference to `kprobe_handler'

Offending commit now dropped, thanks.

> ---------
> 6.1.y:
> 
> Build reference: v6.1.38-393-gb6386e7314b4
> Compiler version: alpha-linux-gcc (GCC) 11.4.0
> Assembler version: GNU assembler (GNU Binutils) 2.40
> 
> Building alpha:allmodconfig ... failed
> Building m68k:allmodconfig ... failed
> --------------
> Error log:
> <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> In file included from block/genhd.c:28:
> block/genhd.c: In function 'disk_release':
> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>    88 | # define blk_trace_remove(q)                            (-ENOTTY)
>       |                                                         ^
> block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
>  1185 |         blk_trace_remove(disk->queue);

Should now be fixed.

> -------------
> 6.4.y:
> 
> Build reference: v6.4.3-548-g5f35ab2efbc9
> Compiler version: alpha-linux-gcc (GCC) 11.4.0
> Assembler version: GNU assembler (GNU Binutils) 2.40
> 
> Building alpha:allmodconfig ... failed
> Building m68k:allmodconfig ... failed
> --------------
> Error log:
> <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> In file included from block/genhd.c:28:
> block/genhd.c: In function 'disk_release':
> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>    88 | # define blk_trace_remove(q)                            (-ENOTTY)
>       |                                                         ^
> block/genhd.c:1175:9: note: in expansion of macro 'blk_trace_remove'
>  1175 |         blk_trace_remove(disk->queue);

Same error?  Ah, needs to go to 6.4.y as well, now queued up.

> Building mips:allmodconfig ... failed
> --------------
> Error log:
> arch/mips/boot/dts/ingenic/ci20.dts:242.19-247.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC1: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:248.18-253.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC2: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:254.18-259.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC3: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:265.17-270.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO5: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:271.18-276.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO6: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:277.20-282.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO7: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:283.20-288.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO8: Reference to non-existent node or label "vcc_33v"
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[3]: [scripts/Makefile.lib:419: arch/mips/boot/dts/ingenic/ci20.dtb] Error 2 (ignored)
> arch/mips/boot/dts/ingenic/ci20.dts:242.19-247.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC1: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:248.18-253.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC2: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:254.18-259.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/DCDC3: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:265.17-270.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO5: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:271.18-276.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO6: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:277.20-282.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO7: Reference to non-existent node or label "vcc_33v"
> arch/mips/boot/dts/ingenic/ci20.dts:283.20-288.6: ERROR (phandle_references): /i2c@10050000/act8600@5a/regulators/LDO8: Reference to non-existent node or label "vcc_33v"
> ERROR: Input tree has errors, aborting (use -f to force output)

Which tree is this failing on?

> On top of the build failures, mcimx7d-sabre emulations crash
> in 6.4.y.queue with a NULL pointer access in ads7846_probe().
> 
> [   15.286830] 8<--- cut here ---
> [   15.287438] Unhandled fault: page domain fault (0x01b) at 0x00001eba
> [   15.287707] [00001eba] *pgd=00000000
> [   15.288503] Internal error: : 1b [#1] SMP ARM
> [   15.288852] Modules linked in:
> [   15.289177] CPU: 0 PID: 29 Comm: kworker/u4:2 Tainted: G                 N 6.4.4-rc1-g5f35ab2efbc9 #1
> [   15.289433] Hardware name: Freescale i.MX7 Dual (Device Tree)
> [   15.289780] Workqueue: events_unbound deferred_probe_work_func
> [   15.290540] PC is at ads7846_probe+0x9f0/0xfa0
> [   15.290701] LR is at _raw_spin_unlock_irqrestore+0x50/0x64
> 
> That is due to it picking up "Input: ads7846 - Convert to use software nodes"
> without its fixes.

Hm, let me run the "find the fixes for the patches in the queue" scripts
now and see what it digs up.

thanks for the report!

greg k-h

Re: Build failures / crashes in stable queue branches

[Joel Fernandes]

On 7/16/23 10:30, Greg KH wrote:
> On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
>> Hi,
>>
>> 在 2023/07/15 23:49, Joel Fernandes 写道:
>>> Hi Yu,
>>>
>>> On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
>>> [..]
>>>> ---------
>>>> 6.1.y:
>>>>
>>>> Build reference: v6.1.38-393-gb6386e7314b4
>>>> Compiler version: alpha-linux-gcc (GCC) 11.4.0
>>>> Assembler version: GNU assembler (GNU Binutils) 2.40
>>>>
>>>> Building alpha:allmodconfig ... failed
>>>> Building m68k:allmodconfig ... failed
>>>> --------------
>>>> Error log:
>>>> <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>>>> In file included from block/genhd.c:28:
>>>> block/genhd.c: In function 'disk_release':
>>>> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>>>>      88 | # define blk_trace_remove(q)                            (-ENOTTY)
>>>>         |                                                         ^
>>>> block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
>>>>    1185 |         blk_trace_remove(disk->queue);
>>>
>>> 6.1 stable is broken and gives build warning without:
>>>
>>> cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
>>>
>>> Could you please submit it to stable for 6.1? (I could have done that but it
>>> looks like you already backported related patches so its best for you to do
>>> it, thanks for your help!).
>>
>> Thanks for the notice, however, I'll suggest to revert this patch for
>> now, because there are follow up fixes that is not applied yet.
> 
> Which specific patch should be dropped?
> 

Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg apply 
the above fix? Let us please keep 6.1 stable unbroken. ;-)

Apologies for my noise if the issue has already been resolved.

  - Joel

Re: Build failures / crashes in stable queue branches

[Greg KH]

On Tue, Jul 18, 2023 at 09:52:45AM -0400, Joel Fernandes wrote:
> On 7/16/23 10:30, Greg KH wrote:
> > On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
> > > Hi,
> > > 
> > > 在 2023/07/15 23:49, Joel Fernandes 写道:
> > > > Hi Yu,
> > > > 
> > > > On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> > > > [..]
> > > > > ---------
> > > > > 6.1.y:
> > > > > 
> > > > > Build reference: v6.1.38-393-gb6386e7314b4
> > > > > Compiler version: alpha-linux-gcc (GCC) 11.4.0
> > > > > Assembler version: GNU assembler (GNU Binutils) 2.40
> > > > > 
> > > > > Building alpha:allmodconfig ... failed
> > > > > Building m68k:allmodconfig ... failed
> > > > > --------------
> > > > > Error log:
> > > > > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > In file included from block/genhd.c:28:
> > > > > block/genhd.c: In function 'disk_release':
> > > > > include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
> > > > >      88 | # define blk_trace_remove(q)                            (-ENOTTY)
> > > > >         |                                                         ^
> > > > > block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
> > > > >    1185 |         blk_trace_remove(disk->queue);
> > > > 
> > > > 6.1 stable is broken and gives build warning without:
> > > > 
> > > > cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
> > > > 
> > > > Could you please submit it to stable for 6.1? (I could have done that but it
> > > > looks like you already backported related patches so its best for you to do
> > > > it, thanks for your help!).
> > > 
> > > Thanks for the notice, however, I'll suggest to revert this patch for
> > > now, because there are follow up fixes that is not applied yet.
> > 
> > Which specific patch should be dropped?
> > 
> 
> Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg
> apply the above fix? Let us please keep 6.1 stable unbroken. ;-)
> 
> Apologies for my noise if the issue has already been resolved.

I think it has been resolved, but testing against the latest -rc release
I sent out yesterday would be appreciated.

thanks,

greg k-h

Re: Build failures / crashes in stable queue branches

[Joel Fernandes]

On Tue, Jul 18, 2023 at 10:45 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 18, 2023 at 09:52:45AM -0400, Joel Fernandes wrote:
> > On 7/16/23 10:30, Greg KH wrote:
> > > On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
> > > > Hi,
> > > >
> > > > 在 2023/07/15 23:49, Joel Fernandes 写道:
> > > > > Hi Yu,
> > > > >
> > > > > On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
> > > > > [..]
> > > > > > ---------
> > > > > > 6.1.y:
> > > > > >
> > > > > > Build reference: v6.1.38-393-gb6386e7314b4
> > > > > > Compiler version: alpha-linux-gcc (GCC) 11.4.0
> > > > > > Assembler version: GNU assembler (GNU Binutils) 2.40
> > > > > >
> > > > > > Building alpha:allmodconfig ... failed
> > > > > > Building m68k:allmodconfig ... failed
> > > > > > --------------
> > > > > > Error log:
> > > > > > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > > In file included from block/genhd.c:28:
> > > > > > block/genhd.c: In function 'disk_release':
> > > > > > include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
> > > > > >      88 | # define blk_trace_remove(q)                            (-ENOTTY)
> > > > > >         |                                                         ^
> > > > > > block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
> > > > > >    1185 |         blk_trace_remove(disk->queue);
> > > > >
> > > > > 6.1 stable is broken and gives build warning without:
> > > > >
> > > > > cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
> > > > >
> > > > > Could you please submit it to stable for 6.1? (I could have done that but it
> > > > > looks like you already backported related patches so its best for you to do
> > > > > it, thanks for your help!).
> > > >
> > > > Thanks for the notice, however, I'll suggest to revert this patch for
> > > > now, because there are follow up fixes that is not applied yet.
> > >
> > > Which specific patch should be dropped?
> > >
> >
> > Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg
> > apply the above fix? Let us please keep 6.1 stable unbroken. ;-)
> >
> > Apologies for my noise if the issue has already been resolved.
>
> I think it has been resolved, but testing against the latest -rc release
> I sent out yesterday would be appreciated.

Great.  Sure, I am going to run it today.


 - Joel

Re: Build failures / crashes in stable queue branches

[Yu Kuai]

Hi,

在 2023/07/19 1:14, Joel Fernandes 写道:
> On Tue, Jul 18, 2023 at 10:45 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>>
>> On Tue, Jul 18, 2023 at 09:52:45AM -0400, Joel Fernandes wrote:
>>> On 7/16/23 10:30, Greg KH wrote:
>>>> On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
>>>>> Hi,
>>>>>
>>>>> 在 2023/07/15 23:49, Joel Fernandes 写道:
>>>>>> Hi Yu,
>>>>>>
>>>>>> On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
>>>>>> [..]
>>>>>>> ---------
>>>>>>> 6.1.y:
>>>>>>>
>>>>>>> Build reference: v6.1.38-393-gb6386e7314b4
>>>>>>> Compiler version: alpha-linux-gcc (GCC) 11.4.0
>>>>>>> Assembler version: GNU assembler (GNU Binutils) 2.40
>>>>>>>
>>>>>>> Building alpha:allmodconfig ... failed
>>>>>>> Building m68k:allmodconfig ... failed
>>>>>>> --------------
>>>>>>> Error log:
>>>>>>> <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>>>>>>> In file included from block/genhd.c:28:
>>>>>>> block/genhd.c: In function 'disk_release':
>>>>>>> include/linux/blktrace_api.h:88:57: error: statement with no effect [-Werror=unused-value]
>>>>>>>       88 | # define blk_trace_remove(q)                            (-ENOTTY)
>>>>>>>          |                                                         ^
>>>>>>> block/genhd.c:1185:9: note: in expansion of macro 'blk_trace_remove'
>>>>>>>     1185 |         blk_trace_remove(disk->queue);
>>>>>>
>>>>>> 6.1 stable is broken and gives build warning without:
>>>>>>
>>>>>> cbe7cff4a76b ("blktrace: use inline function for blk_trace_remove() while blktrace is disabled")
>>>>>>
>>>>>> Could you please submit it to stable for 6.1? (I could have done that but it
>>>>>> looks like you already backported related patches so its best for you to do
>>>>>> it, thanks for your help!).
>>>>>
>>>>> Thanks for the notice, however, I'll suggest to revert this patch for
>>>>> now, because there are follow up fixes that is not applied yet.
>>>>
>>>> Which specific patch should be dropped?
>>>>
>>>
>>> Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg
>>> apply the above fix? Let us please keep 6.1 stable unbroken. ;-)
>>>
>>> Apologies for my noise if the issue has already been resolved.
>>
>> I think it has been resolved, but testing against the latest -rc release
>> I sent out yesterday would be appreciated.
> 
> Great.  Sure, I am going to run it today.

Sorry about the trouble, currently this patch will cause that scsi host
module can't be unloaded, and there are follow up fixes for this:

https://lore.kernel.org/all/20230621160111.1433521-1-yukuai1@huaweicloud.com/
https://lore.kernel.org/all/20230705024001.177585-1-yukuai1@huaweicloud.com/

The second patch is not applied yet, either revert the original patch or
apply the above fix to stable as well.

Thanks,
Kuai
> 
> 
>   - Joel
> .
> 

Re: Build failures / crashes in stable queue branches

[Joel Fernandes]

On 7/18/23 21:16, Yu Kuai wrote:
> Hi,
> 
> 在 2023/07/19 1:14, Joel Fernandes 写道:
>> On Tue, Jul 18, 2023 at 10:45 AM Greg KH <gregkh@linuxfoundation.org> 
>> wrote:
>>>
>>> On Tue, Jul 18, 2023 at 09:52:45AM -0400, Joel Fernandes wrote:
>>>> On 7/16/23 10:30, Greg KH wrote:
>>>>> On Sun, Jul 16, 2023 at 11:20:33AM +0800, Yu Kuai wrote:
>>>>>> Hi,
>>>>>>
>>>>>> 在 2023/07/15 23:49, Joel Fernandes 写道:
>>>>>>> Hi Yu,
>>>>>>>
>>>>>>> On Fri, Jul 14, 2023 at 03:21:46AM -0700, Guenter Roeck wrote:
>>>>>>> [..]
>>>>>>>> ---------
>>>>>>>> 6.1.y:
>>>>>>>>
>>>>>>>> Build reference: v6.1.38-393-gb6386e7314b4
>>>>>>>> Compiler version: alpha-linux-gcc (GCC) 11.4.0
>>>>>>>> Assembler version: GNU assembler (GNU Binutils) 2.40
>>>>>>>>
>>>>>>>> Building alpha:allmodconfig ... failed
>>>>>>>> Building m68k:allmodconfig ... failed
>>>>>>>> --------------
>>>>>>>> Error log:
>>>>>>>> <stdin>:1517:2: warning: #warning syscall clone3 not implemented 
>>>>>>>> [-Wcpp]
>>>>>>>> In file included from block/genhd.c:28:
>>>>>>>> block/genhd.c: In function 'disk_release':
>>>>>>>> include/linux/blktrace_api.h:88:57: error: statement with no 
>>>>>>>> effect [-Werror=unused-value]
>>>>>>>>       88 | # define 
>>>>>>>> blk_trace_remove(q)                            (-ENOTTY)
>>>>>>>>          
>>>>>>>> |                                                         ^
>>>>>>>> block/genhd.c:1185:9: note: in expansion of macro 
>>>>>>>> 'blk_trace_remove'
>>>>>>>>     1185 |         blk_trace_remove(disk->queue);
>>>>>>>
>>>>>>> 6.1 stable is broken and gives build warning without:
>>>>>>>
>>>>>>> cbe7cff4a76b ("blktrace: use inline function for 
>>>>>>> blk_trace_remove() while blktrace is disabled")
>>>>>>>
>>>>>>> Could you please submit it to stable for 6.1? (I could have done 
>>>>>>> that but it
>>>>>>> looks like you already backported related patches so its best for 
>>>>>>> you to do
>>>>>>> it, thanks for your help!).
>>>>>>
>>>>>> Thanks for the notice, however, I'll suggest to revert this patch for
>>>>>> now, because there are follow up fixes that is not applied yet.
>>>>>
>>>>> Which specific patch should be dropped?
>>>>>
>>>>
>>>> Yu: Ping? ;-). Are you suggesting the original set be reverted, or Greg
>>>> apply the above fix? Let us please keep 6.1 stable unbroken. ;-)
>>>>
>>>> Apologies for my noise if the issue has already been resolved.
>>>
>>> I think it has been resolved, but testing against the latest -rc release
>>> I sent out yesterday would be appreciated.
>>
>> Great.  Sure, I am going to run it today.
> 
> Sorry about the trouble, currently this patch will cause that scsi host
> module can't be unloaded, and there are follow up fixes for this:
> 
> https://lore.kernel.org/all/20230621160111.1433521-1-yukuai1@huaweicloud.com/
> https://lore.kernel.org/all/20230705024001.177585-1-yukuai1@huaweicloud.com/
> 
> The second patch is not applied yet, either revert the original patch or
> apply the above fix to stable as well.

The latest 6.1 stable now builds so it is all good.

thanks,

  - Joel