* [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
@ 2025-05-13 3:13 Wayne Lin
2025-05-13 4:44 ` Lin, Wayne
0 siblings, 1 reply; 7+ messages in thread
From: Wayne Lin @ 2025-05-13 3:13 UTC (permalink / raw)
To: amd-gfx @ lists . freedesktop . org--cc=Harry Wentland,
Mario Limonciello, Alex Deucher
Cc: Wayne Lin, stable
It's expected that we'll encounter temporary exceptions
during aux transactions. Adjust logging from drm_info to
drm_dbg_dp to prevent flooding with unnecessary log messages.
Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc: stable@vger.kernel.org
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 0d7b72c75802..25e8befbcc47 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
if (payload.write && result >= 0) {
if (result) {
/*one byte indicating partially written bytes*/
- drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
result = payload.data[0];
} else if (!payload.reply[0])
/*I2C_ACK|AUX_ACK*/
@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
break;
}
- drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
}
if (payload.reply[0])
- drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
payload.reply[0]);
return result;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
@ 2025-05-13 3:20 Wayne Lin
2025-05-13 12:37 ` Alex Deucher
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wayne Lin @ 2025-05-13 3:20 UTC (permalink / raw)
To: amd-gfx; +Cc: Harry Wentland, Mario Limonciello, Alex Deucher, Wayne Lin,
stable
It's expected that we'll encounter temporary exceptions
during aux transactions. Adjust logging from drm_info to
drm_dbg_dp to prevent flooding with unnecessary log messages.
Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
Cc: stable@vger.kernel.org
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 0d7b72c75802..25e8befbcc47 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
if (payload.write && result >= 0) {
if (result) {
/*one byte indicating partially written bytes*/
- drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
result = payload.data[0];
} else if (!payload.reply[0])
/*I2C_ACK|AUX_ACK*/
@@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
break;
}
- drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
}
if (payload.reply[0])
- drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
+ drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
payload.reply[0]);
return result;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
2025-05-13 3:13 Wayne Lin
@ 2025-05-13 4:44 ` Lin, Wayne
0 siblings, 0 replies; 7+ messages in thread
From: Lin, Wayne @ 2025-05-13 4:44 UTC (permalink / raw)
To: Wentland, Harry, Limonciello, Mario, Deucher, Alexander
Cc: stable@vger.kernel.org
[Public]
Sorry for spamming. Due to network issues, didn't successfully send to amd-gfx by this mail.
Have another one sent to amd-gfx. Please ignore this one.
Thanks!
Regards,
Wayne
> -----Original Message-----
> From: Wayne Lin <Wayne.Lin@amd.com>
> Sent: Tuesday, May 13, 2025 11:13 AM
> To: Wentland, Harry <Harry.Wentland@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>
> Cc: Lin, Wayne <Wayne.Lin@amd.com>; stable@vger.kernel.org
> Subject: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
>
> It's expected that we'll encounter temporary exceptions during aux transactions.
> Adjust logging from drm_info to drm_dbg_dp to prevent flooding with unnecessary
> log messages.
>
> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
> Cc: stable@vger.kernel.org
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 0d7b72c75802..25e8befbcc47 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> if (payload.write && result >= 0) {
> if (result) {
> /*one byte indicating partially written bytes*/
> - drm_info(adev_to_drm(adev), "amdgpu: AUX partially
> written\n");
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially
> written\n");
> result = payload.data[0];
> } else if (!payload.reply[0])
> /*I2C_ACK|AUX_ACK*/
> @@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux
> *aux,
> break;
> }
>
> - drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n",
> operation_result);
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer
> fail:%d\n",
> +operation_result);
> }
>
> if (payload.reply[0])
> - drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not
> ACK: 0x%02x.",
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not
> ACK:
> +0x%02x.",
> payload.reply[0]);
>
> return result;
> --
> 2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
2025-05-13 3:20 [PATCH] drm/amd/display: Avoid flooding unnecessary info messages Wayne Lin
@ 2025-05-13 12:37 ` Alex Deucher
2025-05-13 13:35 ` Harry Wentland
2025-05-14 8:11 ` Christian Heusel
2 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2025-05-13 12:37 UTC (permalink / raw)
To: Wayne Lin
Cc: amd-gfx, Harry Wentland, Mario Limonciello, Alex Deucher, stable
On Mon, May 12, 2025 at 11:28 PM Wayne Lin <Wayne.Lin@amd.com> wrote:
>
> It's expected that we'll encounter temporary exceptions
> during aux transactions. Adjust logging from drm_info to
> drm_dbg_dp to prevent flooding with unnecessary log messages.
>
> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
> Cc: stable@vger.kernel.org
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 0d7b72c75802..25e8befbcc47 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> if (payload.write && result >= 0) {
> if (result) {
> /*one byte indicating partially written bytes*/
> - drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> result = payload.data[0];
> } else if (!payload.reply[0])
> /*I2C_ACK|AUX_ACK*/
> @@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> break;
> }
>
> - drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> }
>
> if (payload.reply[0])
> - drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> payload.reply[0]);
>
> return result;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
2025-05-13 3:20 [PATCH] drm/amd/display: Avoid flooding unnecessary info messages Wayne Lin
2025-05-13 12:37 ` Alex Deucher
@ 2025-05-13 13:35 ` Harry Wentland
2025-05-13 13:49 ` Yadav, Arvind
2025-05-14 8:11 ` Christian Heusel
2 siblings, 1 reply; 7+ messages in thread
From: Harry Wentland @ 2025-05-13 13:35 UTC (permalink / raw)
To: Wayne Lin, amd-gfx; +Cc: Mario Limonciello, Alex Deucher, stable
On 2025-05-12 23:20, Wayne Lin wrote:
> It's expected that we'll encounter temporary exceptions
> during aux transactions. Adjust logging from drm_info to
> drm_dbg_dp to prevent flooding with unnecessary log messages.
>
> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
> Cc: stable@vger.kernel.org
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 0d7b72c75802..25e8befbcc47 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> if (payload.write && result >= 0) {
> if (result) {
> /*one byte indicating partially written bytes*/
> - drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
> result = payload.data[0];
> } else if (!payload.reply[0])
> /*I2C_ACK|AUX_ACK*/
> @@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> break;
> }
>
> - drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
> }
>
> if (payload.reply[0])
> - drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
> payload.reply[0]);
>
> return result;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
2025-05-13 13:35 ` Harry Wentland
@ 2025-05-13 13:49 ` Yadav, Arvind
0 siblings, 0 replies; 7+ messages in thread
From: Yadav, Arvind @ 2025-05-13 13:49 UTC (permalink / raw)
To: Harry Wentland, Wayne Lin, amd-gfx
Cc: Mario Limonciello, Alex Deucher, stable
These log messages are overwhelming during the boot process.
Acked-by: Arvind Yadav <Arvind.Yadav@amd.com>
~arvind
On 5/13/2025 7:05 PM, Harry Wentland wrote:
>
> On 2025-05-12 23:20, Wayne Lin wrote:
>> It's expected that we'll encounter temporary exceptions
>> during aux transactions. Adjust logging from drm_info to
>> drm_dbg_dp to prevent flooding with unnecessary log messages.
>>
>> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
>> Cc: stable@vger.kernel.org
>> Cc: Mario Limonciello <mario.limonciello@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> index 0d7b72c75802..25e8befbcc47 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
>> @@ -107,7 +107,7 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
>> if (payload.write && result >= 0) {
>> if (result) {
>> /*one byte indicating partially written bytes*/
>> - drm_info(adev_to_drm(adev), "amdgpu: AUX partially written\n");
>> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX partially written\n");
>> result = payload.data[0];
>> } else if (!payload.reply[0])
>> /*I2C_ACK|AUX_ACK*/
>> @@ -133,11 +133,11 @@ static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
>> break;
>> }
>>
>> - drm_info(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
>> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: DP AUX transfer fail:%d\n", operation_result);
>> }
>>
>> if (payload.reply[0])
>> - drm_info(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
>> + drm_dbg_dp(adev_to_drm(adev), "amdgpu: AUX reply command not ACK: 0x%02x.",
>> payload.reply[0]);
>>
>> return result;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amd/display: Avoid flooding unnecessary info messages
2025-05-13 3:20 [PATCH] drm/amd/display: Avoid flooding unnecessary info messages Wayne Lin
2025-05-13 12:37 ` Alex Deucher
2025-05-13 13:35 ` Harry Wentland
@ 2025-05-14 8:11 ` Christian Heusel
2 siblings, 0 replies; 7+ messages in thread
From: Christian Heusel @ 2025-05-14 8:11 UTC (permalink / raw)
To: Wayne Lin
Cc: amd-gfx, Harry Wentland, Mario Limonciello, Alex Deucher, stable
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On 25/05/13 11:20AM, Wayne Lin wrote:
> It's expected that we'll encounter temporary exceptions
> during aux transactions. Adjust logging from drm_info to
> drm_dbg_dp to prevent flooding with unnecessary log messages.
>
> Fixes: 6285f12bc54c ("drm/amd/display: Fix wrong handling for AUX_DEFER case")
> Cc: stable@vger.kernel.org
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
If it's not already applied it would of course be nice if credit for my
report could be added to the change:
Reported-by: Christian Heusel <christian@heusel.eu>
Link: https://lore.kernel.org/all/32c592ea-0afd-4753-a81d-73021b8e193c@heusel.eu/
Have a nice day everyone!
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-05-14 8:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 3:20 [PATCH] drm/amd/display: Avoid flooding unnecessary info messages Wayne Lin
2025-05-13 12:37 ` Alex Deucher
2025-05-13 13:35 ` Harry Wentland
2025-05-13 13:49 ` Yadav, Arvind
2025-05-14 8:11 ` Christian Heusel
-- strict thread matches above, loose matches on Subject: below --
2025-05-13 3:13 Wayne Lin
2025-05-13 4:44 ` Lin, Wayne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox