[PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[Peter Chen]

It doesn't need to do it, and the related command event returns
'Slot Not Enabled Error' status.

Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
cc: stable@vger.kernel.org
Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
 drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
index fd06cb85c4ea..757fdd918286 100644
--- a/drivers/usb/cdns3/cdnsp-ring.c
+++ b/drivers/usb/cdns3/cdnsp-ring.c
@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id)
 	}
 
 	if (port_id != old_port) {
-		cdnsp_disable_slot(pdev);
+		if (pdev->slot_id)
+			cdnsp_disable_slot(pdev);
+
 		pdev->active_port = port;
 		cdnsp_enable_slot(pdev);
 	}
-- 
2.25.1

回复: [PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[Fugang Duan]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

发件人: Peter Chen <peter.chen@cixtech.com> 发送时间: 2025年6月18日 17:53
>It doesn't need to do it, and the related command event returns 'Slot Not Enabled
>Error' status.
>
>Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD
>Driver")
>cc: stable@vger.kernel.org
>Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
>Signed-off-by: Peter Chen <peter.chen@cixtech.com>

Reviewed-by: Fugang Duan <fugang.duan@cixtech.com>

>---
> drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
>index fd06cb85c4ea..757fdd918286 100644
>--- a/drivers/usb/cdns3/cdnsp-ring.c
>+++ b/drivers/usb/cdns3/cdnsp-ring.c
>@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev,
>u32 port_id)
> 	}
>
> 	if (port_id != old_port) {
>-		cdnsp_disable_slot(pdev);
>+		if (pdev->slot_id)
>+			cdnsp_disable_slot(pdev);
>+
> 		pdev->active_port = port;
> 		cdnsp_enable_slot(pdev);
> 	}
>--
>2.25.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 15184 bytes --]

[PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[Peter Chen]

It doesn't need to do it, and the related command event returns
'Slot Not Enabled Error' status.

Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
cc: stable@vger.kernel.org
Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
Reviewed-by: Fugang Duan <fugang.duan@cixtech.com>
Signed-off-by: Peter Chen <peter.chen@cixtech.com>
---
 drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
index fd06cb85c4ea..757fdd918286 100644
--- a/drivers/usb/cdns3/cdnsp-ring.c
+++ b/drivers/usb/cdns3/cdnsp-ring.c
@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id)
 	}
 
 	if (port_id != old_port) {
-		cdnsp_disable_slot(pdev);
+		if (pdev->slot_id)
+			cdnsp_disable_slot(pdev);
+
 		pdev->active_port = port;
 		cdnsp_enable_slot(pdev);
 	}
-- 
2.25.1

Re: [PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[Greg KH]

On Wed, Jun 18, 2025 at 05:53:21PM +0800, Peter Chen wrote:
> It doesn't need to do it, and the related command event returns
> 'Slot Not Enabled Error' status.
> 
> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
> cc: stable@vger.kernel.org
> Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> ---
>  drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Any reason this wasn't cc:ed the proper mailing lists?

Or is this a stable-kernel-only patch?

confused,

greg k-h

Re: [PATCH 1/1] usb: cdnsp: do not disable slot for disabled slot

[Peter Chen]

On 25-07-01 11:34:46, Greg KH wrote:
> [Some people who received this message don't often get email from gregkh@linuxfoundation.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> On Wed, Jun 18, 2025 at 05:53:21PM +0800, Peter Chen wrote:
> > It doesn't need to do it, and the related command event returns
> > 'Slot Not Enabled Error' status.
> >
> > Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
> > cc: stable@vger.kernel.org
> > Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com>
> > Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> > ---
> >  drivers/usb/cdns3/cdnsp-ring.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Any reason this wasn't cc:ed the proper mailing lists?
> 
> Or is this a stable-kernel-only patch?
> 
> confused,

Sorry, Greg. This is internal review patch for upstream, I forgot to
omit cc list when sending review. Please ignore it.

The formal upstream patch has already sent out to linux-usb mail list.

-- 

Best regards,
Peter