From: Sudeep Holla <sudeep.holla@arm.com>
To: Zhen Ni <zhen.ni@easystack.cn>
Cc: <jassisinghbrar@gmail.com>, <linux-acpi@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v5] mailbox: pcc: Add missed acpi_put_table() to fix memory leak
Date: Thu, 7 Aug 2025 15:13:35 +0100 [thread overview]
Message-ID: <20250807-piquant-dramatic-spaniel-f0f4a0@sudeepholla> (raw)
In-Reply-To: <20250807032831.451863-1-zhen.ni@easystack.cn>
On Thu, Aug 07, 2025 at 11:28:31AM +0800, Zhen Ni wrote:
> Fixes a permanent ACPI memory leak in the success path by adding
> acpi_put_table().
>
NACK as you need to copy all GAS register reference which otherwise would
cause issue as reported to your v4. Sorry I do know I did provide the
Reviewed-by tag as I clearly missed to see this copy of reference to the
GAS registers in the PCCT which is being accessed later which makes it
impossible to drop the table reference unless you copy them to local
structures.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-08-07 14:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730124508.939257-1-zhen.ni@easystack.cn>
2025-08-04 7:41 ` [PATCH v2] mailbox: pcc: Add missed acpi_put_table() to fix memory leak Zhen Ni
2025-08-04 8:42 ` Markus Elfring
2025-08-04 12:14 ` [PATCH v3] " Zhen Ni
2025-08-04 14:06 ` Markus Elfring
2025-08-05 3:48 ` [PATCH v4] " Zhen Ni
2025-08-05 6:28 ` Markus Elfring
2025-08-05 7:26 ` Greg KH
2025-08-06 15:31 ` Sudeep Holla
2025-08-07 3:28 ` [PATCH v5] " Zhen Ni
2025-08-07 14:13 ` Sudeep Holla [this message]
2025-08-07 13:40 ` [PATCH v4] " Aithal, Srikanth
2025-08-07 14:08 ` Sudeep Holla
2025-08-08 4:33 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807-piquant-dramatic-spaniel-f0f4a0@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox