From: Zhen Ni <zhen.ni@easystack.cn>
To: sudeep.holla@arm.com, jassisinghbrar@gmail.com
Cc: linux-acpi@vger.kernel.org, Zhen Ni <zhen.ni@easystack.cn>,
stable@vger.kernel.org
Subject: [PATCH v5] mailbox: pcc: Add missed acpi_put_table() to fix memory leak
Date: Thu, 7 Aug 2025 11:28:31 +0800 [thread overview]
Message-ID: <20250807032831.451863-1-zhen.ni@easystack.cn> (raw)
In-Reply-To: <20250805034829.168187-1-zhen.ni@easystack.cn>
Fixes a permanent ACPI memory leak in the success path by adding
acpi_put_table().
Fixes: ce028702ddbc ("mailbox: pcc: Move bulk of PCCT parsing into pcc_mbox_probe")
Cc: stable@vger.kernel.org
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
---
Changes in v5:
- Discard err label modification
Changes in v4:
- Change goto target from err to put_table.
- Remove goto tatget err_nomem
- Update commit msg
Changes in v3:
- Add goto label err_nomem, keep the err label.
- Update commit msg
Changes in v2:
- Add tags of 'Fixes' and 'Cc'
- Change goto target from out_put_pcct to e_nomem
---
drivers/mailbox/pcc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index f6714c233f5a..70d47f8759eb 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -827,8 +827,6 @@ static int pcc_mbox_probe(struct platform_device *pdev)
rc = mbox_controller_register(pcc_mbox_ctrl);
if (rc)
pr_err("Err registering PCC as Mailbox controller: %d\n", rc);
- else
- return 0;
err:
acpi_put_table(pcct_tbl);
return rc;
--
2.20.1
next prev parent reply other threads:[~2025-08-07 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730124508.939257-1-zhen.ni@easystack.cn>
2025-08-04 7:41 ` [PATCH v2] mailbox: pcc: Add missed acpi_put_table() to fix memory leak Zhen Ni
2025-08-04 8:42 ` Markus Elfring
2025-08-04 12:14 ` [PATCH v3] " Zhen Ni
2025-08-04 14:06 ` Markus Elfring
2025-08-05 3:48 ` [PATCH v4] " Zhen Ni
2025-08-05 6:28 ` Markus Elfring
2025-08-05 7:26 ` Greg KH
2025-08-06 15:31 ` Sudeep Holla
2025-08-07 3:28 ` Zhen Ni [this message]
2025-08-07 14:13 ` [PATCH v5] " Sudeep Holla
2025-08-07 13:40 ` [PATCH v4] " Aithal, Srikanth
2025-08-07 14:08 ` Sudeep Holla
2025-08-08 4:33 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807032831.451863-1-zhen.ni@easystack.cn \
--to=zhen.ni@easystack.cn \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox