From: Markus Elfring <Markus.Elfring@web.de>
To: Zhen Ni <zhen.ni@easystack.cn>, linux-acpi@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v4] mailbox: pcc: Add missed acpi_put_table() to fix memory leak
Date: Tue, 5 Aug 2025 08:28:17 +0200 [thread overview]
Message-ID: <41fdbd2b-92c5-4f11-9c58-aff9b9f35e72@web.de> (raw)
In-Reply-To: <20250805034829.168187-1-zhen.ni@easystack.cn>
> Fixes a permanent ACPI memory leak in the success path by adding
> acpi_put_table().
> Renaming generic 'err' label to 'put_table' for clarity.
Will a desire grow for the usage of imperative mood also in such change descriptions?
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
…> Changes in v4:
> - Change goto target from err to put_table.
Thanks.
> - Remove goto tatget err_nomem
…
Does this adjustment indicate questionable development difficulties?
Regards,
Markus
next prev parent reply other threads:[~2025-08-05 6:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730124508.939257-1-zhen.ni@easystack.cn>
2025-08-04 7:41 ` [PATCH v2] mailbox: pcc: Add missed acpi_put_table() to fix memory leak Zhen Ni
2025-08-04 8:42 ` Markus Elfring
2025-08-04 12:14 ` [PATCH v3] " Zhen Ni
2025-08-04 14:06 ` Markus Elfring
2025-08-05 3:48 ` [PATCH v4] " Zhen Ni
2025-08-05 6:28 ` Markus Elfring [this message]
2025-08-05 7:26 ` Greg KH
2025-08-06 15:31 ` Sudeep Holla
2025-08-07 3:28 ` [PATCH v5] " Zhen Ni
2025-08-07 14:13 ` Sudeep Holla
2025-08-07 13:40 ` [PATCH v4] " Aithal, Srikanth
2025-08-07 14:08 ` Sudeep Holla
2025-08-08 4:33 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41fdbd2b-92c5-4f11-9c58-aff9b9f35e72@web.de \
--to=markus.elfring@web.de \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox