* [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment
@ 2026-11-22 18:50 Nico Pache (Red Hat)
2026-11-22 19:02 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Nico Pache (Red Hat) @ 2026-11-22 18:50 UTC (permalink / raw)
To: linux-mm, linux-kselftest
Cc: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan, Tianyi Chen, stable,
Nico Pache (Red Hat)
The unconditional default assignment overwrites VM_SELFTEST_ITEMS from
the environment. This regresses environments that use the variable to
select test groups: without -t, all default test categories run instead
of the requested groups. The -t option continues to override it.
Fixes: 4844f5b84a8e ("selftests/mm: reject invalid test selections before running tests")
Cc: stable@vger.kernel.org
Signed-off-by: Nico Pache (Red Hat) <nico.pache@linux.dev>
---
tools/testing/selftests/mm/run_vmtests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index a1b45a3dedae..aa63f840cf60 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -102,7 +102,7 @@ RUN_ALL=false
RUN_DESTRUCTIVE=false
TAP_PREFIX="# "
-VM_SELFTEST_ITEMS="default"
+: "${VM_SELFTEST_ITEMS:=default}"
while getopts "aht:nd" OPT; do
case ${OPT} in
---
base-commit: 2dc60bd9975fc8666a13d58410499e06e6799ba9
change-id: 20261122-vm_selftests_items_fix-f118ab78426e
Best regards,
--
Nico Pache (Red Hat) <nico.pache@linux.dev>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment
2026-11-22 18:50 [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment Nico Pache (Red Hat)
@ 2026-11-22 19:02 ` Andrew Morton
2026-11-22 19:15 ` Nico Pache
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2026-11-22 19:02 UTC (permalink / raw)
To: Nico Pache (Red Hat)
Cc: linux-mm, linux-kselftest, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan, Tianyi Chen, stable
On Sun, 22 Nov 2026 11:50:36 -0700 "Nico Pache (Red Hat)" <nico.pache@linux.dev> wrote:
> The unconditional default assignment overwrites VM_SELFTEST_ITEMS from
> the environment. This regresses environments that use the variable to
> select test groups: without -t, all default test categories run instead
> of the requested groups. The -t option continues to override it.
Oh. Is "setenv VM_SELFTEST_ITEMS" really a thing?
afaict the official way of doing this is to use -t. Continuing to
support "setenv VM_SELFTEST_ITEMS" is perpetuating bad behavior. How
about teaching "environments" to use the official selection method?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment
2026-11-22 19:02 ` Andrew Morton
@ 2026-11-22 19:15 ` Nico Pache
0 siblings, 0 replies; 3+ messages in thread
From: Nico Pache @ 2026-11-22 19:15 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-mm, linux-kselftest, David Hildenbrand, Lorenzo Stoakes,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan, Tianyi Chen, stable
On 11/22/26 12:02 PM, Andrew Morton wrote:
> On Sun, 22 Nov 2026 11:50:36 -0700 "Nico Pache (Red Hat)" <nico.pache@linux.dev> wrote:
>
>> The unconditional default assignment overwrites VM_SELFTEST_ITEMS from
>> the environment. This regresses environments that use the variable to
>> select test groups: without -t, all default test categories run instead
>> of the requested groups. The -t option continues to override it.
>
> Oh. Is "setenv VM_SELFTEST_ITEMS" really a thing?
Thats how we've been utilizing it since we added this. It was the
easiest solution for our testing infrastructure.
>
> afaict the official way of doing this is to use -t. Continuing to
> support "setenv VM_SELFTEST_ITEMS" is perpetuating bad behavior. How
> about teaching "environments" to use the official selection method?
Ok, fair enough. I will look into switching over.
Thanks,
-- Nico
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-22 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 18:50 [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment Nico Pache (Red Hat)
2026-11-22 19:02 ` Andrew Morton
2026-11-22 19:15 ` Nico Pache
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox