From: Jiri Slaby <jslaby@suse.cz>
To: Johan Hovold <jhovold@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, stable@vger.kernel.org,
lwn@lwn.net, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH] USB: mos7840: remove unused variable
Date: Sat, 10 Nov 2012 21:41:02 +0100 [thread overview]
Message-ID: <509EBBDE.9020902@suse.cz> (raw)
In-Reply-To: <CAMgPeKUTpA+qn3TA+4xpRa4z_Y1E+6mk+_Xdom+ugdqCttL3aQ@mail.gmail.com>
On 11/08/2012 06:28 PM, Johan Hovold wrote:
> Fix warning about unused variable introduced by commit e681b66f2e19fa
> ("USB: mos7840: remove invalid disconnect handling") upstream.
>
> A subsequent fix which removed the disconnect function got rid of the
> warning but that one was only backported to v3.6.
>
> Reported-by: Jiri Slaby <jslaby@suse.cz>
FWIW Looks good to me.
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
>
> This patch against v3.4 also applies to v3.0 (and v3.2).
>
> Thanks,
> Johan
>
> drivers/usb/serial/mos7840.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 0179d34..c854235 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2581,7 +2581,6 @@ error:
> static void mos7840_disconnect(struct usb_serial *serial)
> {
> int i;
> - unsigned long flags;
> struct moschip_port *mos7840_port;
> dbg("%s", " disconnect :entering..........");
>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-11-10 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 17:28 [PATCH] USB: mos7840: remove unused variable Johan Hovold
2012-11-10 20:41 ` Jiri Slaby [this message]
2012-11-11 22:49 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509EBBDE.9020902@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox