* [PATCH] USB: mos7840: remove unused variable
@ 2012-11-08 17:28 Johan Hovold
2012-11-10 20:41 ` Jiri Slaby
2012-11-11 22:49 ` Ben Hutchings
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2012-11-08 17:28 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, Andrew Morton, torvalds, stable, lwn, Jiri Slaby,
Ben Hutchings, Johan Hovold
Fix warning about unused variable introduced by commit e681b66f2e19fa
("USB: mos7840: remove invalid disconnect handling") upstream.
A subsequent fix which removed the disconnect function got rid of the
warning but that one was only backported to v3.6.
Reported-by: Jiri Slaby <jslaby@suse.cz>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
This patch against v3.4 also applies to v3.0 (and v3.2).
Thanks,
Johan
drivers/usb/serial/mos7840.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 0179d34..c854235 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2581,7 +2581,6 @@ error:
static void mos7840_disconnect(struct usb_serial *serial)
{
int i;
- unsigned long flags;
struct moschip_port *mos7840_port;
dbg("%s", " disconnect :entering..........");
--
1.7.12
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] USB: mos7840: remove unused variable
2012-11-08 17:28 [PATCH] USB: mos7840: remove unused variable Johan Hovold
@ 2012-11-10 20:41 ` Jiri Slaby
2012-11-11 22:49 ` Ben Hutchings
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2012-11-10 20:41 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg KH, linux-kernel, Andrew Morton, torvalds, stable, lwn,
Ben Hutchings
On 11/08/2012 06:28 PM, Johan Hovold wrote:
> Fix warning about unused variable introduced by commit e681b66f2e19fa
> ("USB: mos7840: remove invalid disconnect handling") upstream.
>
> A subsequent fix which removed the disconnect function got rid of the
> warning but that one was only backported to v3.6.
>
> Reported-by: Jiri Slaby <jslaby@suse.cz>
FWIW Looks good to me.
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
>
> This patch against v3.4 also applies to v3.0 (and v3.2).
>
> Thanks,
> Johan
>
> drivers/usb/serial/mos7840.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 0179d34..c854235 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2581,7 +2581,6 @@ error:
> static void mos7840_disconnect(struct usb_serial *serial)
> {
> int i;
> - unsigned long flags;
> struct moschip_port *mos7840_port;
> dbg("%s", " disconnect :entering..........");
>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] USB: mos7840: remove unused variable
2012-11-08 17:28 [PATCH] USB: mos7840: remove unused variable Johan Hovold
2012-11-10 20:41 ` Jiri Slaby
@ 2012-11-11 22:49 ` Ben Hutchings
1 sibling, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2012-11-11 22:49 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg KH, linux-kernel, Andrew Morton, torvalds, stable, lwn,
Jiri Slaby
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Thu, 2012-11-08 at 18:28 +0100, Johan Hovold wrote:
> Fix warning about unused variable introduced by commit e681b66f2e19fa
> ("USB: mos7840: remove invalid disconnect handling") upstream.
>
> A subsequent fix which removed the disconnect function got rid of the
> warning but that one was only backported to v3.6.
>
> Reported-by: Jiri Slaby <jslaby@suse.cz>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
>
> This patch against v3.4 also applies to v3.0 (and v3.2).
[...]
Queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
Design a system any fool can use, and only a fool will want to use it.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-11 22:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 17:28 [PATCH] USB: mos7840: remove unused variable Johan Hovold
2012-11-10 20:41 ` Jiri Slaby
2012-11-11 22:49 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox