* [PATCH v2 1/1] uas: remove can_queue set in host template
@ 2016-05-23 19:28 tom.ty89
2016-05-24 6:58 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: tom.ty89 @ 2016-05-23 19:28 UTC (permalink / raw)
To: gregkh; +Cc: kraxel, stern, linux-usb, linux-scsi, stable, hdegoede, Tom Yan
From: Tom Yan <tom.ty89@gmail.com>
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made
qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant.
Removing it to avoid confusion.
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 4d49fce..e03c490 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -848,7 +848,6 @@ static struct scsi_host_template uas_host_template = {
.slave_configure = uas_slave_configure,
.eh_abort_handler = uas_eh_abort_handler,
.eh_bus_reset_handler = uas_eh_bus_reset_handler,
- .can_queue = MAX_CMNDS,
.this_id = -1,
.sg_tablesize = SG_NONE,
.skip_settle_delay = 1,
--
2.8.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] uas: remove can_queue set in host template
2016-05-23 19:28 [PATCH v2 1/1] uas: remove can_queue set in host template tom.ty89
@ 2016-05-24 6:58 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2016-05-24 6:58 UTC (permalink / raw)
To: tom.ty89, gregkh; +Cc: kraxel, stern, linux-usb, linux-scsi, stable
Hi,
On 23-05-16 21:28, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made
> qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant.
> Removing it to avoid confusion.
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
I agree removing this is good:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 4d49fce..e03c490 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -848,7 +848,6 @@ static struct scsi_host_template uas_host_template = {
> .slave_configure = uas_slave_configure,
> .eh_abort_handler = uas_eh_abort_handler,
> .eh_bus_reset_handler = uas_eh_bus_reset_handler,
> - .can_queue = MAX_CMNDS,
> .this_id = -1,
> .sg_tablesize = SG_NONE,
> .skip_settle_delay = 1,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-24 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 19:28 [PATCH v2 1/1] uas: remove can_queue set in host template tom.ty89
2016-05-24 6:58 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox