From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <maxg@mellanox.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Leon Romanovsky <leon@kernel.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
matanb@mellanox.com, linux-rdma@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] IB/core: Fix different types mix in ib_device_cap_flags structure values
Date: Wed, 1 Jun 2016 18:35:56 +0300 [thread overview]
Message-ID: <574F00DC.5000002@grimberg.me> (raw)
In-Reply-To: <574ECF44.3070003@mellanox.com>
>> Which is clearly wrong. This is because signed int becomes sign
>> extended when converted to uint64_t, corrupting the upper bits.
>>
>> Since adding the ULL's doesn't make the enum constants have uniform
>> type I would not bother with the churn.
>
> tested this with single casting to IB_DEVICE_ON_DEMAND_PAGING (1 << 31)
> to (1ULL << 31). works fine.
> I'll send another patch today.
Good to know, thanks Max.
next prev parent reply other threads:[~2016-06-01 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 10:09 [PATCH] IB/core: Fix different types mix in ib_device_cap_flags structure values Max Gurtovoy
2016-05-31 15:35 ` Bart Van Assche
2016-05-31 17:13 ` Jason Gunthorpe
2016-05-31 17:30 ` Leon Romanovsky
2016-05-31 18:05 ` Bart Van Assche
2016-05-31 18:12 ` Leon Romanovsky
2016-05-31 18:21 ` Jason Gunthorpe
2016-05-31 18:54 ` Leon Romanovsky
2016-05-31 19:39 ` Jason Gunthorpe
2016-06-01 12:04 ` Max Gurtovoy
2016-06-01 15:35 ` Sagi Grimberg [this message]
2016-05-31 18:43 ` Bart Van Assche
2016-05-31 18:16 ` Jason Gunthorpe
2016-05-31 15:36 ` Bart Van Assche
2016-05-31 19:14 ` Max Gurtovoy
2016-05-31 19:16 ` Robert LeBlanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574F00DC.5000002@grimberg.me \
--to=sagi@grimberg.me \
--cc=bart.vanassche@sandisk.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=maxg@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox