* [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required
@ 2016-06-01 11:42 Boris Brezillon
2016-06-02 9:44 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Boris Brezillon @ 2016-06-01 11:42 UTC (permalink / raw)
To: Nicolas Ferre, Jean-Christophe Plagniol-Villard,
Alexandre Belloni, David Airlie, Daniel Vetter, dri-devel
Cc: linux-arm-kernel, Boris Brezillon, stable
The driver is only enabling scaling, but never disabling it, thus, if you
enable the scaling feature once it stays enabled forever.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index aef3ca8..016c191 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
factor_reg);
+ } else {
+ atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required
2016-06-01 11:42 [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required Boris Brezillon
@ 2016-06-02 9:44 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2016-06-02 9:44 UTC (permalink / raw)
To: Boris Brezillon, Jean-Christophe Plagniol-Villard,
Alexandre Belloni, David Airlie, Daniel Vetter, dri-devel
Cc: linux-arm-kernel, stable
Le 01/06/2016 13:42, Boris Brezillon a �crit :
> The driver is only enabling scaling, but never disabling it, thus, if you
> enable the scaling feature once it stays enabled forever.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
> Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
> Cc: <stable@vger.kernel.org>
Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks!
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index aef3ca8..016c191 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
>
> atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
> factor_reg);
> + } else {
> + atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
> }
> }
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-02 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 11:42 [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required Boris Brezillon
2016-06-02 9:44 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox