* [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status [not found] <20180212194630.7216-1-hdegoede@redhat.com> @ 2018-02-12 19:46 ` Hans de Goede 2018-02-12 21:50 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Hans de Goede @ 2018-02-12 19:46 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi; +Cc: Hans de Goede, linux-kernel, stable Some other drivers may be waiting for our extcon to show-up (exiting their probe methods with -EPROBE_DEFER until we show up). These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to process the id-pin before registering the extcon, so that other drivers see the correct state right away. Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Changes in v2: -Add Fixes tag Changes in v3: -Fix oops on probe by scheduling the work too early --- drivers/extcon/extcon-intel-int3496.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c index c8691b5a9cb0..673bb26a9a2a 100644 --- a/drivers/extcon/extcon-intel-int3496.c +++ b/drivers/extcon/extcon-intel-int3496.c @@ -131,11 +131,15 @@ static int int3496_probe(struct platform_device *pdev) if (IS_ERR(data->gpio_usb_mux)) dev_info(dev, "can't request USB MUX GPIO\n"); - /* register extcon device */ data->edev = devm_extcon_dev_allocate(dev, int3496_cable); if (IS_ERR(data->edev)) return -ENOMEM; + /* process id-pin first so that we start with the right status */ + queue_delayed_work(system_wq, &data->work, 0); + flush_delayed_work(&data->work); + + /* register extcon device */ ret = devm_extcon_dev_register(dev, data->edev); if (ret < 0) { dev_err(dev, "can't register extcon device: %d\n", ret); @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) return ret; } - /* queue initial processing of id-pin */ - queue_delayed_work(system_wq, &data->work, 0); - platform_set_drvdata(pdev, data); return 0; -- 2.14.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status 2018-02-12 19:46 ` [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status Hans de Goede @ 2018-02-12 21:50 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2018-02-12 21:50 UTC (permalink / raw) To: Hans de Goede, MyungJoo Ham; +Cc: linux-kernel, stable On 2018년 02월 13일 04:46, Hans de Goede wrote: > Some other drivers may be waiting for our extcon to show-up (exiting their > probe methods with -EPROBE_DEFER until we show up). > > These drivers will typically get the cable state directly after getting > the extcon, this commit changes the int3496 code to process the id-pin > before registering the extcon, so that other drivers see the correct state > right away. > > Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver") > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v2: > -Add Fixes tag > > Changes in v3: > -Fix oops on probe by scheduling the work too early > --- > drivers/extcon/extcon-intel-int3496.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index c8691b5a9cb0..673bb26a9a2a 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -131,11 +131,15 @@ static int int3496_probe(struct platform_device *pdev) > if (IS_ERR(data->gpio_usb_mux)) > dev_info(dev, "can't request USB MUX GPIO\n"); > > - /* register extcon device */ > data->edev = devm_extcon_dev_allocate(dev, int3496_cable); > if (IS_ERR(data->edev)) > return -ENOMEM; > > + /* process id-pin first so that we start with the right status */ > + queue_delayed_work(system_wq, &data->work, 0); > + flush_delayed_work(&data->work); > + > + /* register extcon device */ > ret = devm_extcon_dev_register(dev, data->edev); > if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) > return ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, &data->work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-12 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180212194630.7216-1-hdegoede@redhat.com>
2018-02-12 19:46 ` [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status Hans de Goede
2018-02-12 21:50 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox