* [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free()
@ 2025-05-28 15:42 Jacek Lawrynowicz
2025-05-28 16:33 ` Lizhi Hou
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Lawrynowicz @ 2025-05-28 15:42 UTC (permalink / raw)
To: dri-devel; +Cc: jeff.hugo, lizhi.hou, Jacek Lawrynowicz, stable
Don't WARN if imported buffers are in use in ivpu_gem_bo_free() as they
can be indeed used in the original context/driver.
Fixes: 647371a6609d ("accel/ivpu: Add GEM buffer object management")
Cc: <stable@vger.kernel.org> # v6.3
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
---
drivers/accel/ivpu/ivpu_gem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index 5908268ca45e9..0371a8b4a474f 100644
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -285,7 +285,8 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
list_del(&bo->bo_list_node);
mutex_unlock(&vdev->bo_list_lock);
- drm_WARN_ON(&vdev->drm, !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
+ drm_WARN_ON(&vdev->drm, !bo->base.base.import_attach &&
+ !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
drm_WARN_ON(&vdev->drm, ivpu_bo_size(bo) == 0);
drm_WARN_ON(&vdev->drm, bo->base.vaddr);
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free()
2025-05-28 15:42 [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free() Jacek Lawrynowicz
@ 2025-05-28 16:33 ` Lizhi Hou
2025-05-28 17:04 ` Jacek Lawrynowicz
0 siblings, 1 reply; 3+ messages in thread
From: Lizhi Hou @ 2025-05-28 16:33 UTC (permalink / raw)
To: Jacek Lawrynowicz, dri-devel; +Cc: jeff.hugo, stable
On 5/28/25 08:42, Jacek Lawrynowicz wrote:
> Don't WARN if imported buffers are in use in ivpu_gem_bo_free() as they
> can be indeed used in the original context/driver.
>
> Fixes: 647371a6609d ("accel/ivpu: Add GEM buffer object management")
> Cc: <stable@vger.kernel.org> # v6.3
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_gem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index 5908268ca45e9..0371a8b4a474f 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -285,7 +285,8 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
> list_del(&bo->bo_list_node);
> mutex_unlock(&vdev->bo_list_lock);
>
> - drm_WARN_ON(&vdev->drm, !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
> + drm_WARN_ON(&vdev->drm, !bo->base.base.import_attach &&
> + !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
Probably drm_gem_is_imported()?
Thanks,
Lizhi
> drm_WARN_ON(&vdev->drm, ivpu_bo_size(bo) == 0);
> drm_WARN_ON(&vdev->drm, bo->base.vaddr);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free()
2025-05-28 16:33 ` Lizhi Hou
@ 2025-05-28 17:04 ` Jacek Lawrynowicz
0 siblings, 0 replies; 3+ messages in thread
From: Jacek Lawrynowicz @ 2025-05-28 17:04 UTC (permalink / raw)
To: Lizhi Hou, dri-devel; +Cc: jeff.hugo, stable
Hi,
On 5/28/2025 6:33 PM, Lizhi Hou wrote:
> On 5/28/25 08:42, Jacek Lawrynowicz wrote:
>> Don't WARN if imported buffers are in use in ivpu_gem_bo_free() as they
>> can be indeed used in the original context/driver.
>>
>> Fixes: 647371a6609d ("accel/ivpu: Add GEM buffer object management")
>> Cc: <stable@vger.kernel.org> # v6.3
>> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
>> ---
>> drivers/accel/ivpu/ivpu_gem.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
>> index 5908268ca45e9..0371a8b4a474f 100644
>> --- a/drivers/accel/ivpu/ivpu_gem.c
>> +++ b/drivers/accel/ivpu/ivpu_gem.c
>> @@ -285,7 +285,8 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
>> list_del(&bo->bo_list_node);
>> mutex_unlock(&vdev->bo_list_lock);
>> - drm_WARN_ON(&vdev->drm, !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
>> + drm_WARN_ON(&vdev->drm, !bo->base.base.import_attach &&
>> + !dma_resv_test_signaled(obj->resv, DMA_RESV_USAGE_READ));
>
> Probably drm_gem_is_imported()?
Yep, I will send v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-28 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-28 15:42 [PATCH] accel/ivpu: Fix warning in ivpu_gem_bo_free() Jacek Lawrynowicz
2025-05-28 16:33 ` Lizhi Hou
2025-05-28 17:04 ` Jacek Lawrynowicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox