From: Keith Busch <kbusch@kernel.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
"Cláudio Sampaio" <patola@gmail.com>,
"Felix Yan" <felixonmars@archlinux.org>,
"Sagi Grimberg" <sagi@grimberg.me>,
stable@vger.kernel.org
Subject: Re: [PATCHv2] nvme: avoid bogus CRTO values
Date: Thu, 14 Sep 2023 08:21:03 -0700 [thread overview]
Message-ID: <ZQMk38DogqopZLeo@kbusch-mbp> (raw)
In-Reply-To: <20230913202810.2631288-1-kbusch@meta.com>
On Wed, Sep 13, 2023 at 01:28:10PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Some devices are reporting Controller Ready Modes Supported, but return
> 0 for CRTO. These devices require a much higher time to ready than that,
> so they are failing to initialize after the driver started preferring
> that value over CAP.TO.
>
> The spec requires CAP.TO match the appropritate CRTO value, or be set to
> 0xff if CRTO is larger than that. This means that CAP.TO can be used to
> validate if CRTO is reliable, and provides an appropriate fallback for
> setting the timeout value if not. Use whichever is larger.
I need to send a pull request out today since we're quite a bit behind
as it is. I've applied this for nvme-6.6 now since it fixes a regression
that apparently quite a few people are encountering. If there are any
objections, please let me know by EOD and I'll remove it from the queue.
next prev parent reply other threads:[~2023-09-14 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:28 [PATCHv2] nvme: avoid bogus CRTO values Keith Busch
2023-09-14 15:21 ` Keith Busch [this message]
2023-09-14 19:48 ` Felix Yan
2023-09-14 19:58 ` Keith Busch
2023-09-14 20:07 ` Felix Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQMk38DogqopZLeo@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=felixonmars@archlinux.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=patola@gmail.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox