From: Keith Busch <kbusch@kernel.org>
To: Felix Yan <felixonmars@archlinux.org>
Cc: "Keith Busch" <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de,
"Cláudio Sampaio" <patola@gmail.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
stable@vger.kernel.org
Subject: Re: [PATCHv2] nvme: avoid bogus CRTO values
Date: Thu, 14 Sep 2023 12:58:09 -0700 [thread overview]
Message-ID: <ZQNl0WMd9E8obFcs@kbusch-mbp> (raw)
In-Reply-To: <536c792d-984c-439b-8ee9-25b1bfc5c791@archlinux.org>
On Thu, Sep 14, 2023 at 10:48:55PM +0300, Felix Yan wrote:
>
> Thanks, verified that it works well here.
Thanks, okay if I append your Tested-by: in the patch?
> I noticed only one very small issue: dev_warn_once seems to only print once
> when multiple devices are affected. It may be more ideal if it prints once
> for each device, but I don't know how to really achieve that...
There's no good way to do that, unfortunately. We'd have to create a
custom "print once" based on some driver specific flag for this path,
but that's overkill for this issue, IMO. I feel it should be sufficient
just to know that the fallback is happening, and doesn't really matter
for an admin scanning the logs to see it appear for each device. My main
concern was printing it on every reset; that level of repitition would
definitely cause alarm for some people.
next prev parent reply other threads:[~2023-09-14 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:28 [PATCHv2] nvme: avoid bogus CRTO values Keith Busch
2023-09-14 15:21 ` Keith Busch
2023-09-14 19:48 ` Felix Yan
2023-09-14 19:58 ` Keith Busch [this message]
2023-09-14 20:07 ` Felix Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQNl0WMd9E8obFcs@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=felixonmars@archlinux.org \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=patola@gmail.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox