[PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[Ilikara Zheng]

Secondary temperature thresholds (temp2_{min,max}) were not reported
properly on this NVMe SSD. This resulted in an error while attempting to
read these values with sensors(1):

  ERROR: Can't get value of subfeature temp2_min: I/O error
  ERROR: Can't get value of subfeature temp2_max: I/O error

Add the device to the nvme_id_table with the
NVME_QUIRK_NO_SECONDARY_TEMP_THRESH flag to suppress access to all non-
composite temperature thresholds.

Cc: stable@vger.kernel.org
Signed-off-by: Ilikara Zheng <ilikara@aosc.io>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index e5ca8301bb8b..31049f33f27d 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3997,6 +3997,8 @@ static const struct pci_device_id nvme_id_table[] = {
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
 	{ PCI_DEVICE(0x1e49, 0x0041),   /* ZHITAI TiPro7000 NVMe SSD */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
+	{ PCI_DEVICE(0x1fa0, 0x2283),   /* Wodposit WPBSNM8-256GTP */
+		.driver_data = NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, },
 	{ PCI_DEVICE(0x025e, 0xf1ac),   /* SOLIDIGM  P44 pro SSDPFKKW020X7  */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
 	{ PCI_DEVICE(0xc0a9, 0x540a),   /* Crucial P2 */
-- 
2.52.0

Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[RigoLigo]

Hi all,

On 2025-12-08 21:23, Ilikara Zheng wrote:
> Secondary temperature thresholds (temp2_{min,max}) were not reported
> properly on this NVMe SSD. This resulted in an error while attempting to
> read these values with sensors(1):
> 
>    ERROR: Can't get value of subfeature temp2_min: I/O error
>    ERROR: Can't get value of subfeature temp2_max: I/O error
> 
> Add the device to the nvme_id_table with the
> NVME_QUIRK_NO_SECONDARY_TEMP_THRESH flag to suppress access to all non-
> composite temperature thresholds.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilikara Zheng <ilikara@aosc.io>
> ---
>   drivers/nvme/host/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index e5ca8301bb8b..31049f33f27d 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3997,6 +3997,8 @@ static const struct pci_device_id nvme_id_table[] = {
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0x1e49, 0x0041),   /* ZHITAI TiPro7000 NVMe SSD */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
> +	{ PCI_DEVICE(0x1fa0, 0x2283),   /* Wodposit WPBSNM8-256GTP */
> +		.driver_data = NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, },
>   	{ PCI_DEVICE(0x025e, 0xf1ac),   /* SOLIDIGM  P44 pro SSDPFKKW020X7  */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0xc0a9, 0x540a),   /* Crucial P2 */

I have tested this patch on a CTCISZ 3B6000M-NUC with an exact same SSD 
and this has resolved the error with sensor(1).

Tested-by: Wu Haotian <rigoligo03@gmail.com>

Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[Ilikara Zheng]

Hi all,
Just a gentle ping on this patch.

On 12/8/2025 9:23 PM, Ilikara Zheng wrote:
> Secondary temperature thresholds (temp2_{min,max}) were not reported
> properly on this NVMe SSD. This resulted in an error while attempting to
> read these values with sensors(1):
>
>    ERROR: Can't get value of subfeature temp2_min: I/O error
>    ERROR: Can't get value of subfeature temp2_max: I/O error
>
> Add the device to the nvme_id_table with the
> NVME_QUIRK_NO_SECONDARY_TEMP_THRESH flag to suppress access to all non-
> composite temperature thresholds.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilikara Zheng <ilikara@aosc.io>
> ---
>   drivers/nvme/host/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index e5ca8301bb8b..31049f33f27d 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3997,6 +3997,8 @@ static const struct pci_device_id nvme_id_table[] = {
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0x1e49, 0x0041),   /* ZHITAI TiPro7000 NVMe SSD */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
> +	{ PCI_DEVICE(0x1fa0, 0x2283),   /* Wodposit WPBSNM8-256GTP */
> +		.driver_data = NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, },
>   	{ PCI_DEVICE(0x025e, 0xf1ac),   /* SOLIDIGM  P44 pro SSDPFKKW020X7  */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0xc0a9, 0x540a),   /* Crucial P2 */

Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[Keith Busch]

On Mon, Dec 08, 2025 at 09:23:40PM +0800, Ilikara Zheng wrote:
> +	{ PCI_DEVICE(0x1fa0, 0x2283),   /* Wodposit WPBSNM8-256GTP */

I'm not finding vendor 1FA0 registered on the public pci-ids, nor in the
pcisig.com members list. I just want to make sure the identifier is
officially registered.

Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds

[Ilikara Zheng]

Hi Keith,

On 12/15/2025 11:32 PM, Keith Busch wrote:
> I'm not finding vendor 1FA0 registered on the public pci-ids, nor in the
> pcisig.com members list.

When I run command lspci -vvnnk, I got outputs below:

     01:00.0 Non-Volatile memory controller [0108]: Device [1fa0:2283] 
(prog-if 02 [NVM Express])
             Subsystem: Device [1fa0:2283]
             Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- 
ParErr- Stepping- SERR- FastB2B- DisINTx+
             Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast 
 >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
             Latency: 0
             Interrupt: pin A routed to IRQ 37
             NUMA node: 0
             Region 0: Memory at 40110000 (64-bit, non-prefetchable) 
[size=16K]
             Expansion ROM at 40000000 [disabled] [size=64K]
             Capabilities: <access denied>
             Kernel driver in use: nvme

 > I just want to make sure the identifier is officially registered.

I have no idea why they didn't use their PCI Vendor ID, see 
https://pcisig.com/membership/member-companies where they used a 
different Vendor ID (0x2094).