* [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb()
@ 2026-05-01 20:43 mike.marciniszyn
2026-05-07 18:10 ` Dmitry Ilvokhin
0 siblings, 1 reply; 2+ messages in thread
From: mike.marciniszyn @ 2026-05-01 20:43 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Alex Deucher, Javier Martinez Canillas,
Andrew Lunn
Cc: mike.marciniszyn, dri-devel, linux-kernel, Mike Marciniszyn,
stable
From: Mike Marciniszyn <mmarcini@meta.com>
When CONFIG_DRM_FBDEV_EMULATION is not defined this error results
when building amdgpu_display.c with CONFIG_DRM_AMDGPU:
error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and
later do not support implicit function
declarations [-Wimplicit-function-declaration]
1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
Cc: stable@vger.kernel.org
Signed-off-by: Mike Marciniszyn <mmarcini@meta.com>
---
include/drm/drm_fb_helper.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index bf391903443d..7f9ad421af3f 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -273,6 +273,13 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper);
int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper);
bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
const struct drm_gem_object *obj);
+#else
+static inline bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
+ const struct drm_gem_object *obj)
+{
+ return false;
+}
+
#endif
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb()
2026-05-01 20:43 [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() mike.marciniszyn
@ 2026-05-07 18:10 ` Dmitry Ilvokhin
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Ilvokhin @ 2026-05-07 18:10 UTC (permalink / raw)
To: mike.marciniszyn
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Alex Deucher, Javier Martinez Canillas,
Andrew Lunn, dri-devel, linux-kernel, Mike Marciniszyn, stable
On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote:
> From: Mike Marciniszyn <mmarcini@meta.com>
>
> When CONFIG_DRM_FBDEV_EMULATION is not defined this error results
> when building amdgpu_display.c with CONFIG_DRM_AMDGPU:
>
> error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and
> later do not support implicit function
> declarations [-Wimplicit-function-declaration]
>
> 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Mike Marciniszyn <mmarcini@meta.com>
Just hit the same problem, thanks for the fix.
Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-07 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 20:43 [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() mike.marciniszyn
2026-05-07 18:10 ` Dmitry Ilvokhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox