Re: Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree

Re: Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree

[Qingfang Deng]

Hi,

On 7/29/2026 2:24 AM, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>      selftests: net: test PPPoE packets in gro.sh
> 
> to the 7.1-stable tree which can be found at:
>      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>       selftests-net-test-pppoe-packets-in-gro.sh.patch
> and it can be found in the queue-7.1 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit f9d9bd13a591537a14c39d0221818180960fc0a3
> Author: Qingfang Deng <qingfang.deng@linux.dev>
> Date:   Wed May 13 09:33:49 2026 +0800
> 
>      selftests: net: test PPPoE packets in gro.sh
>      
>      [ Upstream commit 6160ec9d03d7af5aa345b8b994de80fa8454274b ]
>      
>      Add PPPoE test-cases to the GRO selftest. Only run a subset of
>      common_tests to avoid changing the hardcoded L3 offsets everywhere.
>      Add a new "pppoe_sid" test case to verify that packets with different
>      PPPoE session IDs are correctly identified as separate flows and not
>      coalesced.
>      
>      Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
>      Link: https://patch.msgid.link/20260513013400.7467-2-qingfang.deng@linux.dev
>      Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>      Stable-dep-of: c25dd7439f84 ("selftests: drv-net: add missing kconfig for psp.py")
>      Signed-off-by: Sasha Levin <sashal@kernel.org>

Add: Matthieu

PPPoE GRO is not supported by kernel version 7.1, so this test will 
always fail. Please instead rebase the dep commit.

Best regards,

Qingfang

Re: Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree

[Matthieu Baerts]

Hello,

On 29/07/2026 00:58, Qingfang Deng wrote:
> Hi,
> 
> On 7/29/2026 2:24 AM, Sasha Levin wrote:
>> This is a note to let you know that I've just added the patch titled
>>
>>      selftests: net: test PPPoE packets in gro.sh
>>
>> to the 7.1-stable tree which can be found at:
>>      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
>> queue.git;a=summary
>>
>> The filename of the patch is:
>>       selftests-net-test-pppoe-packets-in-gro.sh.patch
>> and it can be found in the queue-7.1 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit f9d9bd13a591537a14c39d0221818180960fc0a3
>> Author: Qingfang Deng <qingfang.deng@linux.dev>
>> Date:   Wed May 13 09:33:49 2026 +0800
>>
>>      selftests: net: test PPPoE packets in gro.sh
>>           [ Upstream commit 6160ec9d03d7af5aa345b8b994de80fa8454274b ]
>>           Add PPPoE test-cases to the GRO selftest. Only run a subset of
>>      common_tests to avoid changing the hardcoded L3 offsets everywhere.
>>      Add a new "pppoe_sid" test case to verify that packets with
>> different
>>      PPPoE session IDs are correctly identified as separate flows and not
>>      coalesced.
>>           Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
>>      Link: https://patch.msgid.link/20260513013400.7467-2-
>> qingfang.deng@linux.dev
>>      Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>>      Stable-dep-of: c25dd7439f84 ("selftests: drv-net: add missing
>> kconfig for psp.py")
>>      Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Add: Matthieu
> 
> PPPoE GRO is not supported by kernel version 7.1, so this test will
> always fail. Please instead rebase the dep commit.

I guess without this patch, there is a conflict because these two lines
are not in the config file:

 CONFIG_PPP=y
 CONFIG_PPPOE=y

The conflict should be easy to solve, simply by adding ...

 CONFIG_NET_SCH_INGRESS=y

... after

 CONFIG_NET_SCH_FQ=m

Cheers,
Matt

Re: Patch "selftests: net: test PPPoE packets in gro.sh" has been added to the 7.1-stable tree

[Sasha Levin]

> PPPoE GRO is not supported by kernel version 7.1, so this test will 
> always fail. Please instead rebase the dep commit.

Dropped 6160ec9d03d7 ("selftests: net: test PPPoE packets in gro.sh") from
the 7.1 queue, and re-applied c25dd7439f84 ("selftests: drv-net: add
missing kconfig for psp.py") on its own using Matthieu's resolution
(CONFIG_NET_SCH_INGRESS=y after CONFIG_NET_SCH_FQ=m).

Thanks to you both for catching it.

-- 
Thanks,
Sasha