From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: tools@linux.kernel.org
Subject: Re: b4 send --output-dir eml's sent with git send-email creates two From: in the mail body
Date: Wed, 19 Oct 2022 15:32:08 -0400 [thread overview]
Message-ID: <20221019193208.euw2lv2d2anpzvdf@meerkat.local> (raw)
In-Reply-To: <9bdb42f7-661a-77ed-97e5-33ba7a31fd9e@theobroma-systems.com>
On Wed, Oct 19, 2022 at 06:23:09PM +0200, Quentin Schulz wrote:
> Hi,
>
> I recently encountered some issue with my particular setup.
>
> https://lore.kernel.org/lkml/20221019-upstream-puma-sd-40mhz-v1-0-754a76421518@theobroma-systems.com/raw
> is the problematic mail, note the two From: lines in the mail body.
>
> This particular patch has a git author (Jakob) different from my local git
> identity (Quentin Schulz <quentin.schulz at theobroma-systems.com>) which is
> different from the sendemail.from configuration (Quentin Schulz <foss+kernel
> at 0leil.net>).
I'm going to point fingers at git-send-email here, because it shouldn't stick
another From: into the body when it already sees a From: there. You should
report this to git maintainers as a bug.
That said...
> The eml file created by b4 send --output-dir has the From: field using the
> current git identity which I assume is the issue.
Right, we're not doing quite the right thing here either, because when there's
a sendemail.from set up, we should be using that instead of the user.name +
user.email. I'll see how we can fix this up to do the right thing.
Thank you for the report.
-K
next prev parent reply other threads:[~2022-10-19 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 16:23 b4 send --output-dir eml's sent with git send-email creates two From: in the mail body Quentin Schulz
2022-10-19 19:32 ` Konstantin Ryabitsev [this message]
2022-10-20 9:03 ` Quentin Schulz
2022-10-21 19:57 ` Bjorn Helgaas
2022-10-31 21:09 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019193208.euw2lv2d2anpzvdf@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox