From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: b4 send --output-dir eml's sent with git send-email creates two From: in the mail body
Date: Thu, 20 Oct 2022 11:03:13 +0200 [thread overview]
Message-ID: <e45c9949-c3d1-302f-5694-b60da7b9579c@theobroma-systems.com> (raw)
In-Reply-To: <20221019193208.euw2lv2d2anpzvdf@meerkat.local>
Hi Konstantin,
On 10/19/22 21:32, Konstantin Ryabitsev wrote:
> On Wed, Oct 19, 2022 at 06:23:09PM +0200, Quentin Schulz wrote:
>> Hi,
>>
>> I recently encountered some issue with my particular setup.
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_lkml_20221019-2Dupstream-2Dpuma-2Dsd-2D40mhz-2Dv1-2D0-2D754a76421518-40theobroma-2Dsystems.com_raw&d=DwIBaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=3N_s7FaOdYHdJMby-XVFQf58qtINncJFtBc_oRqX8C4u5PcoifqemzDuWAyza5ef&s=9tuNrkRYhAXplODVZKdP3zXXV8R8IDPhP5XNItUrsrM&e=
>> is the problematic mail, note the two From: lines in the mail body.
>>
>> This particular patch has a git author (Jakob) different from my local git
>> identity (Quentin Schulz <quentin.schulz at theobroma-systems.com>) which is
>> different from the sendemail.from configuration (Quentin Schulz <foss+kernel
>> at 0leil.net>).
>
> I'm going to point fingers at git-send-email here, because it shouldn't stick
> another From: into the body when it already sees a From: there. You should
> report this to git maintainers as a bug.
>
https://lore.kernel.org/git/09e125ea-5ea5-40c8-575e-57cb7e1806ff@theobroma-systems.com/
is the bug report to git community if anyone wants to follow the
discussion there.
> That said...
>
>> The eml file created by b4 send --output-dir has the From: field using the
>> current git identity which I assume is the issue.
>
> Right, we're not doing quite the right thing here either, because when there's
> a sendemail.from set up, we should be using that instead of the user.name +
> user.email. I'll see how we can fix this up to do the right thing.
>
Lemme know if there's anything I can help with or test.
> Thank you for the report.
>
Thanks for the tool, it's been something I've been wanting to have for a
while already (not a maintainer, but the shazam+prep combo is awesome
and I'm very much looking forward to the --compare-to feature that was
recently added).
Cheers,
Quentin
next prev parent reply other threads:[~2022-10-20 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 16:23 b4 send --output-dir eml's sent with git send-email creates two From: in the mail body Quentin Schulz
2022-10-19 19:32 ` Konstantin Ryabitsev
2022-10-20 9:03 ` Quentin Schulz [this message]
2022-10-21 19:57 ` Bjorn Helgaas
2022-10-31 21:09 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e45c9949-c3d1-302f-5694-b60da7b9579c@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox