From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
tools@linux.kernel.org
Subject: Re: b4 send --output-dir eml's sent with git send-email creates two From: in the mail body
Date: Mon, 31 Oct 2022 17:09:55 -0400 [thread overview]
Message-ID: <20221031210955.o5e4saatypmdfizc@nitro.local> (raw)
In-Reply-To: <20221021195727.GA303980@bhelgaas>
On Fri, Oct 21, 2022 at 02:57:27PM -0500, Bjorn Helgaas wrote:
> > > The eml file created by b4 send --output-dir has the From: field using the
> > > current git identity which I assume is the issue.
> >
> > Right, we're not doing quite the right thing here either, because when there's
> > a sendemail.from set up, we should be using that instead of the user.name +
> > user.email. I'll see how we can fix this up to do the right thing.
>
> I think I'm seeing a similar issue. I have:
>
> [user]
> name = Bjorn Helgaas
> email = bhelgaas@google.com
>
> [sendemail]
> from = Bjorn Helgaas <helgaas@kernel.org>
I have a fix in master and stable-0.10.y that should do the right thing when
sendemail.from is set. I still need to write tests for it, but it appears to
be doing the right thing.
Best regards,
Konstantin
prev parent reply other threads:[~2022-10-31 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 16:23 b4 send --output-dir eml's sent with git send-email creates two From: in the mail body Quentin Schulz
2022-10-19 19:32 ` Konstantin Ryabitsev
2022-10-20 9:03 ` Quentin Schulz
2022-10-21 19:57 ` Bjorn Helgaas
2022-10-31 21:09 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031210955.o5e4saatypmdfizc@nitro.local \
--to=konstantin@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox