b4 patch subject issue

b4 patch subject issue

[Alexandre Belloni]

Hello Konstantin,

I found a small issue in how b4 handles path subjects:

linux$ b4 shazam -tsl 5640233.DvuYhMxLoT@kreacher
Grabbing thread from lore.kernel.org/all/5640233.DvuYhMxLoT%40kreacher/t.mbox.gz
Checking for newer revisions on https://lore.kernel.org/all/
Analyzing 9 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2 1/5] rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()
    + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
    + Link: https://lore.kernel.org/r/4803444.31r3eYUQgx@kreacher
    + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  [PATCH v2 2/5] rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()
    + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
    + Link: https://lore.kernel.org/r/2143522.irdbgypaU6@kreacher
    + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  [PATCH v2 3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions
    + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
    + Link: https://lore.kernel.org/r/13157911.uLZWGnKmhe@kreacher
    + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  [PATCH v2 4/5] rtc: rtc-cmos: Rename ACPI-related functions
    + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
    + Link: https://lore.kernel.org/r/3225614.44csPzL39Z@kreacher
    + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  [PATCH v2 5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal
    + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
    + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
    + Link: https://lore.kernel.org/r/2224609.iZASKD2KPV@kreacher
    + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
Total patches: 5
---
Applying: rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()
Applying: rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()
Applying: rtc: rtc-cmos:
Applying: rtc: rtc-cmos: Rename ACPI-related functions
Applying: rtc: rtc-cmos: Disable ACPI RTC event on removal
---
Patchwork: setting state on patchwork.ozlabs.org/rtc-linux
 -> under-review : [v2,1/5] rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()
 -> under-review : [v2,2/5] rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()
 -> under-review : [v2,3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions
 -> under-review : [v2,4/5] rtc: rtc-cmos: Rename ACPI-related functions
 -> under-review : [v2,5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal
linux$ git log --oneline -5
dfe59ef27467 (HEAD -> plop) rtc: rtc-cmos: Disable ACPI RTC event on removal
f02e8f979e26 rtc: rtc-cmos: Rename ACPI-related functions
a9f73fde7380 rtc: rtc-cmos:
70258aa62244 rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()
1c399f3090f7 rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()

For some reason, 3/5 is losing its full subject. I didn't investigate
but I'm using a freshly updated b4 0.10.1 on fedora.

Let me know if I can be of any assistance to debug that.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: b4 patch subject issue

[Konstantin Ryabitsev]

On Tue, Nov 15, 2022 at 09:17:57PM +0100, Alexandre Belloni wrote:
> Hello Konstantin,
> 
> I found a small issue in how b4 handles path subjects:
> 
> linux$ b4 shazam -tsl 5640233.DvuYhMxLoT@kreacher

...

>   [PATCH v2 3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions
>     + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
>     + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
>     + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
>     + Link: https://lore.kernel.org/r/13157911.uLZWGnKmhe@kreacher
>     + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

If you look at that message (via the link above), you'll see that it has an
in-body "Subject:" line:

	From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
	Subject: [PATCH] rtc: rtc-cmos: 

I have no idea how it ended up there (you'd have to ask Rafael), but git will
always use the in-body "Subject:" header when it sees it.

Best regards,
Konstantin

Re: b4 patch subject issue

[Alexandre Belloni]

On 15/11/2022 15:28:51-0500, Konstantin Ryabitsev wrote:
> On Tue, Nov 15, 2022 at 09:17:57PM +0100, Alexandre Belloni wrote:
> > Hello Konstantin,
> > 
> > I found a small issue in how b4 handles path subjects:
> > 
> > linux$ b4 shazam -tsl 5640233.DvuYhMxLoT@kreacher
> 
> ...
> 
> >   [PATCH v2 3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions
> >     + Reviewed-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
> >     + Tested-by: Zhang Rui <rui.zhang@intel.com> (✓ DKIM/intel.com)
> >     + Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (✓ DKIM/intel.com)
> >     + Link: https://lore.kernel.org/r/13157911.uLZWGnKmhe@kreacher
> >     + Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> If you look at that message (via the link above), you'll see that it has an
> in-body "Subject:" line:
> 
> 	From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 	Subject: [PATCH] rtc: rtc-cmos: 
> 
> I have no idea how it ended up there (you'd have to ask Rafael), but git will
> always use the in-body "Subject:" header when it sees it.
> 

Ah, yes! Thanks for the fast reply!


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com