public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dimitar Penev <dpn@switchfin.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Blackfin: br4: new board port
Date: Mon, 28 Nov 2011 13:45:12 +0200	[thread overview]
Message-ID: <001301ccadc3$30140c70$2901a8c0@dpn> (raw)
In-Reply-To: 20111127222315.20B111FFB3AB@gemini.denx.de

Dear Wolfgang Denk,

> Dear Mike Frysinger,

>
>> > > +#define CONFIG_HOSTNAME br4
>> > > +#define CONFIG_IPADDR 192.168.1.100
>> > > +#define CONFIG_GATEWAYIP 192.168.1.1
>> > > +#define CONFIG_SERVERIP 192.168.1.2
>> > > +#define CONFIG_TFTP_BLOCKSIZE 4404
>> >
>> > NAK.
>>
>> i'm guessing you're only NAK-ing the middle three lines
>
> Right.
>
> I have to admit that I'm not sure i having the last ine is a clever
> idea, but in any case it's not my problem.

I have not dug in the code to understand the impact in details but what I 
have observed is that the
tftp transfer in our local network is getting speeded up few times with the 
last line added.
It is for the files in the 10 MB size range in case it matters.

Probably you can just mention the expected negative side of this line?

Thank you
Dimitar Penev

>
> Best regards,
>
> Wolfgang Denk
>
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> He'd heard her use that sweet, innocent  tone  of  voice  before.  It
> meant that, pretty soon, there was going to be trouble.
>                                        - Terry Pratchett, _Truckers_
> 

  reply	other threads:[~2011-11-28 11:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 17:35 [U-Boot] [PATCH] Blackfin: br4: new board port Dimitar Penev
2011-11-25 21:14 ` Mike Frysinger
2011-11-26 15:32   ` Dimitar Penev
2011-11-27 14:53   ` Wolfgang Denk
2011-11-27 14:56   ` Wolfgang Denk
2011-11-27 20:00     ` Mike Frysinger
2011-11-27 22:23       ` Wolfgang Denk
2011-11-28 11:45         ` Dimitar Penev [this message]
2011-11-28 15:33           ` Wolfgang Denk
2012-01-08  9:21             ` Mike Frysinger
2011-11-27 14:40 ` Wolfgang Denk
2011-11-28  8:29   ` Dimitar Penev
2011-11-28 15:12     ` Wolfgang Denk
2011-11-28 23:15       ` Dimitar Penev
2012-01-08  9:25 ` [U-Boot] [PATCH v2] " Mike Frysinger
2012-01-09 17:18   ` Dimitar Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001301ccadc3$30140c70$2901a8c0@dpn' \
    --to=dpn@switchfin.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox