From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Blackfin: br4: new board port
Date: Sun, 27 Nov 2011 15:00:48 -0500 [thread overview]
Message-ID: <201111271500.49624.vapier@gentoo.org> (raw)
In-Reply-To: <20111127145621.087EF1FFB3AB@gemini.denx.de>
On Sunday 27 November 2011 09:56:20 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > +#ifndef __ADSPBF534__
> > +#define ADI_CMDS_NETWORK 1
> > +#define CONFIG_BFIN_MAC
> > +#define CONFIG_NETCONSOLE 1
>
> These #defines should have no values.
i'll send a global cleanup patch for all the Blackfin boards
> > +#define CONFIG_HOSTNAME br4
> > +#define CONFIG_IPADDR 192.168.1.100
> > +#define CONFIG_GATEWAYIP 192.168.1.1
> > +#define CONFIG_SERVERIP 192.168.1.2
> > +#define CONFIG_TFTP_BLOCKSIZE 4404
>
> NAK.
i'm guessing you're only NAK-ing the middle three lines
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111127/cfd6cde7/attachment.pgp>
next prev parent reply other threads:[~2011-11-27 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 17:35 [U-Boot] [PATCH] Blackfin: br4: new board port Dimitar Penev
2011-11-25 21:14 ` Mike Frysinger
2011-11-26 15:32 ` Dimitar Penev
2011-11-27 14:53 ` Wolfgang Denk
2011-11-27 14:56 ` Wolfgang Denk
2011-11-27 20:00 ` Mike Frysinger [this message]
2011-11-27 22:23 ` Wolfgang Denk
2011-11-28 11:45 ` Dimitar Penev
2011-11-28 15:33 ` Wolfgang Denk
2012-01-08 9:21 ` Mike Frysinger
2011-11-27 14:40 ` Wolfgang Denk
2011-11-28 8:29 ` Dimitar Penev
2011-11-28 15:12 ` Wolfgang Denk
2011-11-28 23:15 ` Dimitar Penev
2012-01-08 9:25 ` [U-Boot] [PATCH v2] " Mike Frysinger
2012-01-09 17:18 ` Dimitar Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111271500.49624.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox