[U-Boot] [PATCH] Blackfin: br4: new board port

[Wolfgang Denk <wd@denx.de>]

Dear Mike Frysinger,

In message <201111271500.49624.vapier@gentoo.org> you wrote:
>
> > > +#ifndef __ADSPBF534__
> > > +#define ADI_CMDS_NETWORK	1
> > > +#define CONFIG_BFIN_MAC
> > > +#define CONFIG_NETCONSOLE	1
> > 
> > These #defines should have no values.
>
> i'll send a global cleanup patch for all the Blackfin boards

Thanks.  But this patch shouldbe fixed before it gets merged.

> > > +#define CONFIG_HOSTNAME		br4
> > > +#define CONFIG_IPADDR		192.168.1.100
> > > +#define CONFIG_GATEWAYIP	192.168.1.1
> > > +#define CONFIG_SERVERIP		192.168.1.2
> > > +#define CONFIG_TFTP_BLOCKSIZE	4404
> > 
> > NAK.
>
> i'm guessing you're only NAK-ing the middle three lines

Right.

I have to admit that I'm not sure i having the last ine is a clever
idea, but in any case it's not my problem.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd heard her use that sweet, innocent  tone  of  voice  before.  It
meant that, pretty soon, there was going to be trouble.
                                        - Terry Pratchett, _Truckers_