[PATCH] Add CONFIG_GICV3 for ARCH_QEMU

[PATCH] Add CONFIG_GICV3 for ARCH_QEMU

[Chan Kim]

I'm trying sending a patch for the first time.
I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt
machine, we need CONFIG_GICV3.
And for the GICV3 related to be compiled, we need to add GICD_BASE,
GICR_BASE defined by the qemu arm64 virt machine.

Signed-off-by : Chan Kim <ckim@etri.re.kr>

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 99264a6478..437857b188 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1044,6 +1044,7 @@ config ARCH_QEMU
 	select DM_SERIAL
 	select OF_CONTROL
 	select PL01X_SERIAL
+	select GICV3
 	imply CMD_DM
 	imply DM_RNG
 	imply DM_RTC
diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
index e296f39879..979ae1815d 100644
--- a/include/configs/qemu-arm.h
+++ b/include/configs/qemu-arm.h
@@ -11,4 +11,6 @@
 
 /* For timer, QEMU emulates an ARMv7/ARMv8 architected timer */
 
+#define GICD_BASE		0x8000000	/* 24MHz, FPGA runs at 5MHz
*/
+#define GICR_BASE		0x80a0000	/* 24MHz, FPGA runs at 5MHz
*/
 #endif /* __CONFIG_H */

Thanks!
Chan Kim

Re: [PATCH] Add CONFIG_GICV3 for ARCH_QEMU

[Simon Glass]

Hi Chan,

On Mon, 5 Jun 2023 at 02:40, Chan Kim <ckim@etri.re.kr> wrote:
>
>
> I'm trying sending a patch for the first time.
> I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt
> machine, we need CONFIG_GICV3.
> And for the GICV3 related to be compiled, we need to add GICD_BASE,
> GICR_BASE defined by the qemu arm64 virt machine.
>
> Signed-off-by : Chan Kim <ckim@etri.re.kr>
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 99264a6478..437857b188 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1044,6 +1044,7 @@ config ARCH_QEMU
>         select DM_SERIAL
>         select OF_CONTROL
>         select PL01X_SERIAL
> +       select GICV3
>         imply CMD_DM
>         imply DM_RNG
>         imply DM_RTC
> diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> index e296f39879..979ae1815d 100644
> --- a/include/configs/qemu-arm.h
> +++ b/include/configs/qemu-arm.h
> @@ -11,4 +11,6 @@
>
>  /* For timer, QEMU emulates an ARMv7/ARMv8 architected timer */
>
> +#define GICD_BASE              0x8000000       /* 24MHz, FPGA runs at 5MHz
> */
> +#define GICR_BASE              0x80a0000       /* 24MHz, FPGA runs at 5MHz
> */
>  #endif /* __CONFIG_H */
>
> Thanks!
> Chan Kim

Thank you for the fix!

This patch is corrupt. You could try using 'patman' to send your patches.

Also, for your commit message, say something like "Without CONFIG_xxx
Linux does not boot on board xxx. Add this to resolve the problem"

You don't want things like "I'm trying to send" in the git history.

Regards,
Simon

>
>
>
>

Re: [PATCH] Add CONFIG_GICV3 for ARCH_QEMU

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Mon, Jun 05, 2023 at 10:40:26AM +0900, Chan Kim wrote:

> I'm trying sending a patch for the first time.
> I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt
> machine, we need CONFIG_GICV3.
> And for the GICV3 related to be compiled, we need to add GICD_BASE,
> GICR_BASE defined by the qemu arm64 virt machine.
> 
> Signed-off-by : Chan Kim <ckim@etri.re.kr>

So I think some more investigation or explanation is needed here.  These
changes cause the way we currently run the qemu arm64 platform in CI to
no longer boot.  See
https://source.denx.de/u-boot/u-boot-test-hooks/-/blob/master/bin/travis-ci/conf.qemu_arm64_na
for details on how that is.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]