public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: <869470483@qq.com>, <u-boot@lists.denx.de>
Cc: <peng.fan@nxp.com>, "'xiefei'" <xf_hqu@163.com>
Subject: RE: [PATCH] mmc:Remove thr legacy mode clock setting operation
Date: Thu, 13 Jul 2023 08:53:54 +0900	[thread overview]
Message-ID: <044801d9b51c$1d96bcb0$58c43610$@samsung.com> (raw)
In-Reply-To: <tencent_BD6D63383BB69B0DE65EA6A888975336C307@qq.com>

Hi,

> -----Original Message-----
> From: 869470483@qq.com <869470483@qq.com>
> Sent: Wednesday, July 12, 2023 4:19 PM
> To: u-boot@lists.denx.de
> Cc: peng.fan@nxp.com; jh80.chung@samsung.com; xiefei <xf_hqu@163.com>
> Subject: [PATCH] mmc:Remove thr legacy mode clock setting operation
> 
> From: xiefei <xf_hqu@163.com>
> 
> Due to the need to read the register value before
> switching to hs mode, the standard protocol does
> not explicitly specify that the setting before
> switching to hs mode is in legacy mode. Therefore,
> the code at this point may cause communication
> abnormalities between the host and card

Thanks for resend patch after updated.
Which board and driver does it occur the issue? 

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: xiefei <xf_hqu@163.com>
> ---
>  drivers/mmc/mmc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 1af6af82e6..96cc7e7332 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2136,9 +2136,7 @@ static int mmc_select_mode_and_width(struct mmc *mmc, uint card_caps)
>  	    mmc->selected_mode == MMC_HS_400 ||
>  	    mmc->selected_mode == MMC_HS_400_ES)
>  		mmc_set_card_speed(mmc, MMC_HS, true);
> -	else
>  #endif
> -		mmc_set_clock(mmc, mmc->legacy_speed, MMC_CLK_ENABLE);
> 
>  	for_each_mmc_mode_by_pref(card_caps, mwt) {
>  		for_each_supported_width(card_caps & mwt->widths,
> --
> 2.17.1



           reply	other threads:[~2023-07-12 23:54 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tencent_BD6D63383BB69B0DE65EA6A888975336C307@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='044801d9b51c$1d96bcb0$58c43610$@samsung.com' \
    --to=jh80.chung@samsung.com \
    --cc=869470483@qq.com \
    --cc=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    --cc=xf_hqu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox