* RE: [PATCH] mmc:Remove thr legacy mode clock setting operation
[not found] ` <tencent_BD6D63383BB69B0DE65EA6A888975336C307@qq.com>
@ 2023-07-12 23:53 ` Jaehoon Chung
0 siblings, 0 replies; only message in thread
From: Jaehoon Chung @ 2023-07-12 23:53 UTC (permalink / raw)
To: 869470483, u-boot; +Cc: peng.fan, 'xiefei'
Hi,
> -----Original Message-----
> From: 869470483@qq.com <869470483@qq.com>
> Sent: Wednesday, July 12, 2023 4:19 PM
> To: u-boot@lists.denx.de
> Cc: peng.fan@nxp.com; jh80.chung@samsung.com; xiefei <xf_hqu@163.com>
> Subject: [PATCH] mmc:Remove thr legacy mode clock setting operation
>
> From: xiefei <xf_hqu@163.com>
>
> Due to the need to read the register value before
> switching to hs mode, the standard protocol does
> not explicitly specify that the setting before
> switching to hs mode is in legacy mode. Therefore,
> the code at this point may cause communication
> abnormalities between the host and card
Thanks for resend patch after updated.
Which board and driver does it occur the issue?
Best Regards,
Jaehoon Chung
>
> Signed-off-by: xiefei <xf_hqu@163.com>
> ---
> drivers/mmc/mmc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 1af6af82e6..96cc7e7332 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2136,9 +2136,7 @@ static int mmc_select_mode_and_width(struct mmc *mmc, uint card_caps)
> mmc->selected_mode == MMC_HS_400 ||
> mmc->selected_mode == MMC_HS_400_ES)
> mmc_set_card_speed(mmc, MMC_HS, true);
> - else
> #endif
> - mmc_set_clock(mmc, mmc->legacy_speed, MMC_CLK_ENABLE);
>
> for_each_mmc_mode_by_pref(card_caps, mwt) {
> for_each_supported_width(card_caps & mwt->widths,
> --
> 2.17.1
^ permalink raw reply [flat|nested] only message in thread