From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 06/11] gpio: stmfx: rename function used to change pin configuration
Date: Thu, 2 Jul 2020 07:51:55 +0000 [thread overview]
Message-ID: <08b8fca7-dc38-e9cd-71a6-3a87910f647c@st.com> (raw)
In-Reply-To: <20200604123033.25499-4-patrick.delaunay@st.com>
Hi Patrick
On 6/4/20 2:30 PM, Patrick Delaunay wrote:
> Rename the two function used to change the pin configuration
> from stmfx_pinctrl_.. stmfx_conf_... to clarify the function usage.
>
> No functional change.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
> Changes in v2:
> - NEW: split previous patch [5/5] gpio: stmfx: add set_config ops
>
> drivers/pinctrl/pinctrl-stmfx.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
> index d74121725c..657ca2e240 100644
> --- a/drivers/pinctrl/pinctrl-stmfx.c
> +++ b/drivers/pinctrl/pinctrl-stmfx.c
> @@ -74,8 +74,7 @@ static int stmfx_write(struct udevice *dev, uint offset, unsigned int val)
> return dm_i2c_reg_write(dev_get_parent(dev), offset, val);
> }
>
> -static int stmfx_pinctrl_set_pupd(struct udevice *dev,
> - unsigned int pin, u32 pupd)
> +static int stmfx_conf_set_pupd(struct udevice *dev, unsigned int pin, u32 pupd)
> {
> u8 reg = STMFX_REG_GPIO_PUPD + get_reg(pin);
> u32 mask = get_mask(pin);
> @@ -89,8 +88,7 @@ static int stmfx_pinctrl_set_pupd(struct udevice *dev,
> return stmfx_write(dev, reg, ret);
> }
>
> -static int stmfx_pinctrl_set_type(struct udevice *dev,
> - unsigned int pin, u32 type)
> +static int stmfx_conf_set_type(struct udevice *dev, unsigned int pin, u32 type)
> {
> u8 reg = STMFX_REG_GPIO_TYPE + get_reg(pin);
> u32 mask = get_mask(pin);
> @@ -235,22 +233,22 @@ static int stmfx_pinctrl_conf_set(struct udevice *dev, unsigned int pin,
> case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT:
> case PIN_CONFIG_BIAS_DISABLE:
> case PIN_CONFIG_DRIVE_PUSH_PULL:
> - ret = stmfx_pinctrl_set_type(dev, pin, 0);
> + ret = stmfx_conf_set_type(dev, pin, 0);
> break;
> case PIN_CONFIG_BIAS_PULL_DOWN:
> - ret = stmfx_pinctrl_set_type(dev, pin, 1);
> + ret = stmfx_conf_set_type(dev, pin, 1);
> if (ret)
> return ret;
> - ret = stmfx_pinctrl_set_pupd(dev, pin, 0);
> + ret = stmfx_conf_set_pupd(dev, pin, 0);
> break;
> case PIN_CONFIG_BIAS_PULL_UP:
> - ret = stmfx_pinctrl_set_type(dev, pin, 1);
> + ret = stmfx_conf_set_type(dev, pin, 1);
> if (ret)
> return ret;
> - ret = stmfx_pinctrl_set_pupd(dev, pin, 1);
> + ret = stmfx_conf_set_pupd(dev, pin, 1);
> break;
> case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> - ret = stmfx_pinctrl_set_type(dev, pin, 1);
> + ret = stmfx_conf_set_type(dev, pin, 1);
> break;
> case PIN_CONFIG_OUTPUT:
> ret = stmfx_gpio_direction_output(plat->gpio, pin, arg);
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
next prev parent reply other threads:[~2020-07-02 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 12:30 [PATCH v2 00/11] stm32mp1: activate gpio hog support and add new pinctrl ops Patrick Delaunay
2020-06-04 12:30 ` [PATCH v2 01/11] configs: stm32mp1: activate CONFIG_GPIO_HOG Patrick Delaunay
2020-07-02 7:41 ` [Uboot-stm32] " Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 02/11] board: stm32mp1: update the gpio hog support Patrick Delaunay
2020-07-02 7:42 ` [Uboot-stm32] " Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 03/11] gpio: stm32: add ops set_dir_flags Patrick Delaunay
2020-07-02 7:48 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 04/11] gpio: stm32: add ops get_dir_flags Patrick Delaunay
2020-07-02 7:51 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 05/11] gpio: stmfx: move function to prepare new ops introduction Patrick Delaunay
2020-07-02 7:51 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 06/11] gpio: stmfx: rename function used to change pin configuration Patrick Delaunay
2020-07-02 7:51 ` Patrice CHOTARD [this message]
2020-06-04 12:30 ` [PATCH v2 07/11] gpio: stmfx: add function stmfx_read_reg and stmfx_write_reg Patrick Delaunay
2020-07-02 7:56 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 08/11] gpio: stmfx: add ops set_dir_flag Patrick Delaunay
2020-07-02 7:58 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 09/11] gpio: stmfx: add ops get_dir_flags Patrick Delaunay
2020-07-02 7:58 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 10/11] pinctrl: stmfx: add information on pin configuration Patrick Delaunay
2020-07-02 7:59 ` Patrice CHOTARD
2020-06-04 12:30 ` [PATCH v2 11/11] pinctrl: stm32: " Patrick Delaunay
2020-07-02 8:02 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08b8fca7-dc38-e9cd-71a6-3a87910f647c@st.com \
--to=patrice.chotard@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox