From: Chris Packham <judge.packham@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
Date: Wed, 23 Jul 2014 12:08:32 +1200 [thread overview]
Message-ID: <1406074112-18161-1-git-send-email-judge.packham@gmail.com> (raw)
file_size was being calculated using back-ticks but map_size uses
$(shell ...). Update the file_size calculation to use $(shell ...).
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
The back ticks didn't work in my environment (GNU Make 3.81). Updating
to use $(shell ...) makes sense from a consistency view even if the
problem is my environment.
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ca212b5..f6a0f68 100644
--- a/Makefile
+++ b/Makefile
@@ -786,7 +786,7 @@ u-boot.hex u-boot.srec: u-boot FORCE
OBJCOPYFLAGS_u-boot.bin := -O binary
binary_size_check: u-boot.bin System.map FORCE
- @file_size=`stat -c %s u-boot.bin` ; \
+ file_size=$(shell stat -c %s u-boot.bin) ; \
map_size=$(shell cat System.map | \
awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
| bc); \
--
1.7.9.5
next reply other threads:[~2014-07-23 0:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 0:08 Chris Packham [this message]
2014-07-23 10:27 ` [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Simon Glass
2014-07-23 18:03 ` Tom Rini
2014-07-23 19:24 ` Jeroen Hofstee
2014-07-23 20:07 ` Tom Rini
2014-07-24 5:14 ` Chris Packham
2014-07-24 5:27 ` [U-Boot] [PATCH] Makefile: use u-boot.map for binary_size_check Chris Packham
2014-07-24 8:31 ` Wolfgang Denk
2014-07-24 13:50 ` Tom Rini
2014-07-24 21:08 ` Chris Packham
2014-08-10 22:22 ` [U-Boot] " Tom Rini
2014-07-25 14:14 ` [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406074112-18161-1-git-send-email-judge.packham@gmail.com \
--to=judge.packham@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox