From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
Date: Wed, 23 Jul 2014 14:03:50 -0400 [thread overview]
Message-ID: <20140723180350.GE1847@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ0qCzdK5Kr7L0iND0wWTBF8Z6u1Y-20VnREW_dDLJZGxw@mail.gmail.com>
On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote:
> On 22 July 2014 18:08, Chris Packham <judge.packham@gmail.com> wrote:
> > file_size was being calculated using back-ticks but map_size uses
> > $(shell ...). Update the file_size calculation to use $(shell ...).
> >
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> But you might want to look at this.
>
> http://patchwork.ozlabs.org/patch/371936/
Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )?
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140723/b9d9fd8c/attachment.pgp>
next prev parent reply other threads:[~2014-07-23 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 0:08 [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Chris Packham
2014-07-23 10:27 ` Simon Glass
2014-07-23 18:03 ` Tom Rini [this message]
2014-07-23 19:24 ` Jeroen Hofstee
2014-07-23 20:07 ` Tom Rini
2014-07-24 5:14 ` Chris Packham
2014-07-24 5:27 ` [U-Boot] [PATCH] Makefile: use u-boot.map for binary_size_check Chris Packham
2014-07-24 8:31 ` Wolfgang Denk
2014-07-24 13:50 ` Tom Rini
2014-07-24 21:08 ` Chris Packham
2014-08-10 22:22 ` [U-Boot] " Tom Rini
2014-07-25 14:14 ` [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723180350.GE1847@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox