From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: use u-boot.map for binary_size_check
Date: Thu, 24 Jul 2014 09:50:29 -0400 [thread overview]
Message-ID: <20140724135029.GH1847@bill-the-cat> (raw)
In-Reply-To: <20140724083114.099343822C9@gemini.denx.de>
On Thu, Jul 24, 2014 at 10:31:14AM +0200, Wolfgang Denk wrote:
> Dear Chris Packham,
>
> In message <1406179627-9496-1-git-send-email-judge.packham@gmail.com> you wrote:
> > u-boot.map is generated automatically by the compiler and more
> > importantly can handle addresses >4GB.
> ...
> > > I think it should be possible to change binary_size_check to use
> > > u-boot.map instead of System.map but would that be OK for all
> > > architectures?
> ...
> > Something like this works for me but maybe there is a way to get nm to handle
> > addresses >4GB.
> ...
> > + map_size=$(shell cat u-boot.map | \
> > awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
> > + | sed 's/0X//g' \
>
>
> Do we _really_ need all of this?
>
> This looks very much like creaping featurism to me...
So it's a safetey check. The various linker script clean-ups we've been
doing have introduced a problem from time to time and binary_check_size
gives a sanity check. This just fixes a corner case in the test.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140724/89be7428/attachment.pgp>
next prev parent reply other threads:[~2014-07-24 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 0:08 [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Chris Packham
2014-07-23 10:27 ` Simon Glass
2014-07-23 18:03 ` Tom Rini
2014-07-23 19:24 ` Jeroen Hofstee
2014-07-23 20:07 ` Tom Rini
2014-07-24 5:14 ` Chris Packham
2014-07-24 5:27 ` [U-Boot] [PATCH] Makefile: use u-boot.map for binary_size_check Chris Packham
2014-07-24 8:31 ` Wolfgang Denk
2014-07-24 13:50 ` Tom Rini [this message]
2014-07-24 21:08 ` Chris Packham
2014-08-10 22:22 ` [U-Boot] " Tom Rini
2014-07-25 14:14 ` [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724135029.GH1847@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox